Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #17669 +/- ##
============================================
+ Coverage 40.38% 40.42% +0.04%
Complexity 2574 2574
============================================
Files 5178 5179 +1
Lines 349134 349239 +105
Branches 44665 44673 +8
============================================
+ Hits 140988 141188 +200
+ Misses 208146 208051 -95 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jt2594838
reviewed
May 14, 2026
Comment on lines
+254
to
260
| public synchronized boolean shouldListenToTsFile() { | ||
| return listenToTsFileSourceCount > 0; | ||
| } | ||
|
|
||
| public synchronized boolean shouldListenToInsertNode() { | ||
| return listenToInsertNodeSourceCount > 0; | ||
| } |
Contributor
There was a problem hiding this comment.
Necessary to synchronize?
Comment on lines
+57
to
65
| dataRegionId2Assigner.compute( | ||
| dataRegionId, | ||
| (id, assigner) -> { | ||
| final PipeDataRegionAssigner actualAssigner = | ||
| assigner == null ? new PipeDataRegionAssigner(dataRegionId) : assigner; | ||
| actualAssigner.startAssignTo(source); | ||
| return actualAssigner; | ||
| }); | ||
| } |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As the title said.
This PR has:
for an unfamiliar reader.
for code coverage.
Key changed/added classes (or packages if there are too many classes) in this PR