[INLONG-12137][Audit] Resolve thread-safety issues in the Audit SDK under high concurrency#12138
Merged
Merged
Conversation
…nder high concurrency
…nder high concurrency
luchunliang
approved these changes
Jun 3, 2026
aloyszhang
approved these changes
Jun 3, 2026
dockerzhang
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The Audit SDK is called concurrently by multi-threaded components but is not thread-safe: non-thread-safe containers and non-atomic counter updates in the aggregation path cause lost/duplicated metrics and intermittent ConcurrentModificationException / NullPointerException. All public APIs (add / send / flush) should be thread-safe by contract.
Modifications
Replaced unsafe containers and counters in the aggregation path with ConcurrentHashMap and LongAdder / AtomicLong, reworked flush/send into a snapshot-and-swap path so producers and the flush thread never block or lose entries, and ensured all public APIs (add / send / flush) only operate on thread-safe state. Added N×M concurrent unit tests asserting exact totals with no exceptions.