IGNITE-28770 : Introduce a operation context attributes registry v2#13243
Open
Vladsz83 wants to merge 32 commits into
Open
IGNITE-28770 : Introduce a operation context attributes registry v2#13243Vladsz83 wants to merge 32 commits into
Vladsz83 wants to merge 32 commits into
Conversation
…-attributes-registry
…-attributes-registry
…-attributes-registry_v2
petrov-mg
reviewed
Jun 19, 2026
petrov-mg
reviewed
Jun 19, 2026
petrov-mg
reviewed
Jun 19, 2026
petrov-mg
reviewed
Jun 19, 2026
petrov-mg
reviewed
Jun 22, 2026
petrov-mg
reviewed
Jun 22, 2026
…-attributes-registry_v2
Contributor
|
It's also worth adding meaningful comments describing the purpose of DistributedOperationContextManager and its methods. What is DistributedOperationContextMessage and why was it decided to use a bitmap. |
petrov-mg
reviewed
Jun 22, 2026
petrov-mg
reviewed
Jun 22, 2026
petrov-mg
reviewed
Jun 22, 2026
petrov-mg
reviewed
Jun 22, 2026
petrov-mg
reviewed
Jun 22, 2026
petrov-mg
reviewed
Jun 22, 2026
| "join request (consider increasing 'joinTimeout' configuration property) " + | ||
| "[joinTimeout=" + spi.joinTimeout + ", sock=" + currSock + ']')); | ||
|
|
||
| if (msg instanceof TcpDiscoveryAbstractMessage msg0 && msg0.opCtxMsg != null) { |
Contributor
There was a problem hiding this comment.
Let's just leave the method as is, but wrap all of its code in a try-with-resource block.
Contributor
Author
There was a problem hiding this comment.
I cannot wrap entire code because there would not be a message yet.
Contributor
There was a problem hiding this comment.
Obviously, that's not what I meant. Let's wrap the code related to processing of the message from the moment it is polled from the queue, but not move anything to other new methods.
In the current state of the code, moving the message handling logic into a separate method seems awkward. It's better to refactor this later in a separate ticket.
Contributor
Author
There was a problem hiding this comment.
We've already moved message processing in a dedicated methods in same manner at other places. Message is a Object here, not even a Message. I need to check its type first. An if is required. That is why I introduce a method or did the processing in the part of code before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.