IGNITE-28209 Throw RecipientLeftException more often in MessagingService#7778
Open
ibessonov wants to merge 3 commits intoapache:mainfrom
Open
IGNITE-28209 Throw RecipientLeftException more often in MessagingService#7778ibessonov wants to merge 3 commits intoapache:mainfrom
ibessonov wants to merge 3 commits intoapache:mainfrom
Conversation
Signed-off-by: ibessonov <bessonov.ip@gmail.com>
Signed-off-by: ibessonov <bessonov.ip@gmail.com>
rpuch
reviewed
Mar 13, 2026
| } | ||
|
|
||
| @Test | ||
| void respondingWhenSenderIsNotInTopologyResultsInFailingFuture() throws Exception { |
Contributor
Author
There was a problem hiding this comment.
It is duplicated by other test now
|
|
||
| @ParameterizedTest | ||
| @EnumSource(SendByConsistentCoordinateOperation.class) | ||
| void sendByConsistentIdToStaleNode(SendByConsistentCoordinateOperation operation) throws Exception { |
Contributor
There was a problem hiding this comment.
It looks like the test actually tests a send to a node that is not in the topology, but its name (and some code in it) is about staleness. Will the test behave the same if we don't mark a node as stale?
Contributor
Author
There was a problem hiding this comment.
Let's see, I'll add another test to be safe
Signed-off-by: ibessonov <bessonov.ip@gmail.com>
rpuch
reviewed
Mar 13, 2026
| var staleIdDetector = new InMemoryStaleIds(); | ||
| staleIdDetector.markAsStale(missingNodeId); | ||
|
|
||
| when(topologyService.getByConsistentId(missingNodeName)).thenReturn(null); |
Contributor
There was a problem hiding this comment.
Why is this needed here? It is still about a missing node, not about a stale node
Contributor
Author
There was a problem hiding this comment.
This test is for a stale node, there's another test for a missing node
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-28209
Thank you for submitting the pull request.
To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:
The Review Checklist
- There is a single JIRA ticket related to the pull request.
- The web-link to the pull request is attached to the JIRA ticket.
- The JIRA ticket has the Patch Available state.
- The description of the JIRA ticket explains WHAT was made, WHY and HOW.
- The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
Notes