feat(js): add TCP/TLS integration tests and examples#2822
Open
atharvalade wants to merge 2 commits intoapache:masterfrom
Open
feat(js): add TCP/TLS integration tests and examples#2822atharvalade wants to merge 2 commits intoapache:masterfrom
atharvalade wants to merge 2 commits intoapache:masterfrom
Conversation
Contributor
Author
|
Resolved |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2822 +/- ##
============================================
- Coverage 71.44% 71.37% -0.08%
Complexity 708 708
============================================
Files 969 970 +1
Lines 78219 78372 +153
Branches 60029 60029
============================================
+ Hits 55884 55935 +51
- Misses 20002 20104 +102
Partials 2333 2333
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
TLS e2e tests for ping, login, message flow, and plain TCP failure scenario
fd8dfee to
95f2cb0
Compare
0ba93fc to
f850eef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2808
Rationale
No TLS integration tests or TLS examples existed for the Node.js SDK despite full TLS transport support.
What changed?
The Node.js SDK had TLS transport implemented via
createTlsSocket()but no tests exercising it and no examples showing usage.Added TLS e2e tests in
foreign/node/src/e2e/tls.system.e2e.tscovering ping, login, stats, send/poll messages over TLS, and plain TCP failure when TLS is required. Addedtcp-tls/producer.tsandtcp-tls/consumer.tsexamples usingtransport: 'TLS'with custom CA certificate fromcore/certs/.Local Execution
Passed.
eslintclean on bothexamples/nodeandforeign/node.AI Usage
getting-startedexamples andtcp.system.e2e.tstest patterns