feat(server): delete segments command for http#2804
Open
dajneem23 wants to merge 5 commits intoapache:masterfrom
Open
feat(server): delete segments command for http#2804dajneem23 wants to merge 5 commits intoapache:masterfrom
dajneem23 wants to merge 5 commits intoapache:masterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2804 +/- ##
============================================
- Coverage 68.44% 68.40% -0.05%
Complexity 656 656
============================================
Files 852 853 +1
Lines 68196 68214 +18
Branches 59657 59685 +28
============================================
- Hits 46679 46661 -18
- Misses 19187 19209 +22
- Partials 2330 2344 +14
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
caec235 to
94b141b
Compare
94b141b to
4625029
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2722
Rationale
delete_segmentsalready exists in binary/CLI/MCP and the HTTP SDK client already sends it, but the server HTTP API had no matching handler, so requests returned404. This left HTTP behavior inconsistent with other transports.What changed?
cargo fmt --all,cargo check -p server,cargo test -p integration --test mod --no-runcargo test --package integration --test mod -- server::general::authentication --nocapturedelete_segmentsincore/server/src/http/segments.rs, following the same flow as partitions: parse path/query, validate, run permission check, -calldelete_segments_base, and applyDeleteSegmentsstate command./streams/{stream_id}/topics/{topic_id}/partitions/{partition_id}withDELETE.core/integration/tests/server/scenarios/system_scenario.rsto calldelete_segmentsat the end and verify partitionsegments_countbefore/after.web/docs/server-api.httpwith:Local Execution
Passed:
cargo fmt --allcargo check -p servercargo test -p integration --test mod --no-runcargo test --package integration --test mod -- server::general::authentication --nocapturePre-commit hooks ran: ran
AI Usage