feat(cpp): Add bazel building and testing infrastructure#2785
feat(cpp): Add bazel building and testing infrastructure#2785slbotbm wants to merge 2 commits intoapache:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2785 +/- ##
============================================
- Coverage 68.44% 67.98% -0.47%
- Complexity 656 708 +52
============================================
Files 852 873 +21
Lines 68196 69744 +1548
Branches 59657 60433 +776
============================================
+ Hits 46679 47416 +737
- Misses 19187 19975 +788
- Partials 2330 2353 +23
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Nice work on the infra setup. the CI integration and Bazel config are clean. Two things to fix before merge though: the |
|
@atharvalade thanks for the review! those were some things that had been left over from when I was experimenting with the public interface. I've standardized all of the getter functions and corrected the bazel build file as well. |
foreign/cpp/BUILD.bazel
Outdated
| find "target/$$PROFILE/build" -name lib.rs.h | head -n 1 | xargs -I{} cp {} "$$OUT_RS" | ||
| find "target/$$PROFILE/build" -name cxx.h | head -n 1 | xargs -I{} cp {} "$$OUT_CXX" |
There was a problem hiding this comment.
not a fan of this. what if find returns 0 results?
also, find | xargs without -print0/-0 breaks on filenames with spaces
|
@hubcio Thanks for the review. I'll address the other two comments after thinking about the best approach |
Which issue does this PR close?
Closes #2762
Rationale
What changed?
Adds bazel build system + stub classes and their tests + ci scripts
Local Execution
AI Usage
If AI tools were used, please answer: