Core, Open-API: Use String.replace for literal replacements - #17484
Open
uros-b wants to merge 2 commits into
Open
Core, Open-API: Use String.replace for literal replacements#17484uros-b wants to merge 2 commits into
uros-b wants to merge 2 commits into
Conversation
operationType and fromType replaced single literal characters using String.replaceAll, which compiles a regex Pattern on every call. The patterns contain no regex metacharacters, so this switches to the char-based String.replace, avoiding the per-call compilation. Behavior-identical.
uros-b
commented
Aug 2, 2026
uros-b
left a comment
Member
Author
There was a problem hiding this comment.
Waiting for CI, cc @szehon-ho for review
nssalian
approved these changes
Aug 3, 2026
ebyhr
reviewed
Aug 3, 2026
Member
Author
|
Good catch, thank you @ebyhr! |
Member
|
We can update more: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several places used String.replaceAll with literal (non-regex) patterns, which compiles a regex Pattern on every call. Switch these to the char/CharSequence String.replace overloads, which avoid the per-call compilation. Behavior-identical.