Docs: Recommend switch expressions in AGENTS.md code style - #17357
Merged
Conversation
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
nssalian
reviewed
Jul 24, 2026
| - Comments and Javadocs should describe the current behavior or contract, not how it changed over time. | ||
| - `} else {` on same line. Minimize variable scope. `try-with-resources` for all `AutoCloseable`. | ||
| - Prefer method references over lambdas. Wrap lines at the highest semantic level. | ||
| - Prefer switch expressions (`case X -> ...`) over statement switches; an exhaustive enum switch needs no `default`. |
Collaborator
There was a problem hiding this comment.
The current line only tells the agent half of it ("enum switch needs no default") and could lead an agent to strip the default from a String switch.
Something like this might be complete:
Prefer switch expressions (case X -> ...) over statement switches. An exhaustive enum switch needs no default. For
String/non-exhaustive switches, the required default should throw an informative error (e.g. Unsupported X), not a generic one.
Contributor
Author
There was a problem hiding this comment.
Good catch on the risk of over-generalizing. I want to keep the bullet terse to match the surrounding style, and I'd rather leave the informative-error-message advice out of this one since it's really about exception messages, not switches. Pushed a tighter version:
Prefer switch expressions (
case X -> ...) over statement switches. Exhaustive enum switches need nodefault; others must have one.
WDYT?
nssalian
approved these changes
Jul 24, 2026
uros-b
approved these changes
Jul 24, 2026
szehon-ho
approved these changes
Jul 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is surfaced by @gaborkaszab in his review comment.