GCP: Fix LICENSE, NOTICE, and runtime-deps for gcp-bundle#16182
Open
kevinjqliu wants to merge 5 commits intoapache:mainfrom
Open
GCP: Fix LICENSE, NOTICE, and runtime-deps for gcp-bundle#16182kevinjqliu wants to merge 5 commits intoapache:mainfrom
kevinjqliu wants to merge 5 commits intoapache:mainfrom
Conversation
kevinjqliu
commented
May 1, 2026
| This product bundles MSV xsdlib (shaded by Woodstox). | ||
|
|
||
| Project URL: https://github.com/xmlark/msv | ||
| License: BSD 3-Clause |
Contributor
Author
There was a problem hiding this comment.
kevinjqliu
commented
May 1, 2026
| | in some artifacts (usually source distributions); but is always available | ||
| | from the source code management (SCM) system project uses. | ||
| | | ||
| | ## FastDoubleParser |
Contributor
Author
There was a problem hiding this comment.
matches aws-bundle
Lines 35 to 60 in 6ce5026
kevinjqliu
commented
May 1, 2026
|
|
||
| -------------------------------------------------------------------------------- | ||
|
|
||
| This product bundles isorelax (bundled by Woodstox). |
Contributor
Author
There was a problem hiding this comment.
aihuaxu
approved these changes
May 2, 2026
aef6b64 to
b557294
Compare
b557294 to
80a92dd
Compare
kevinjqliu
commented
May 4, 2026
rdblue
reviewed
May 5, 2026
rdblue
reviewed
May 5, 2026
RussellSpitzer
approved these changes
May 5, 2026
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Contributor
Author
|
Thanks for the reviews, added some formatting changes. Remove |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes license compliance gaps in
gcp-bundlefound by auditing the shadow JAR contents against LICENSE/NOTICE declarations.Exclude logging dependencies, following same pattern in #16105
Build and verify
./gradlew :iceberg-gcp-bundle:shadowJar -x test ./gradlew :iceberg-gcp-bundle:checkRuntimeDeps JAR=gcp-bundle/build/libs/iceberg-gcp-bundle-1.11.0-SNAPSHOT.jarLICENSE
(In the order of changes in LICENSE)
com/fasterxml/jackson/core/internal/shaded/fdp/. Jackson ships aFastDoubleParser-NOTICEdeclaring the code derives from fast_float (MIT, Copyright 2021 The fast_float authors) and bigint (BSD 2-Clause, Copyright 2020 Tim Buktu). Those licenses require preserving copyright notices in redistributions. Required: consistent with all other Iceberg modules.netty-tcnative-boringssl-staticviagrpc-netty-shaded. BoringSSL is Apache 2.0 but contains portions under the Go License (BSD 3-Clause). Removed redundant inline Apache 2.0 full text (Iceberg is already Apache 2.0), keeping only the BSD 3-Clause Go Authors portion. Tomcat Native (Apache 2.0) is a URL pointer consistent with existing convention.CDDL→CDDL 1.1for javax.annotation-api — Required: Category B license, corrected imprecise reference, full text now included.checker-qual→checker-qual and checker-compat-qual— compat-qual classes are present. Required: checker-compat-qual is MIT-licensed, must be declared.grpc-xds. Not strictly required but consistent with existing convention (file already lists ~30 Apache 2.0 deps).JCTools (via Netty)→JCTools (via Netty and OpenTelemetry)— JCTools (Apache 2.0, v3.1.0) is shaded into three locations:io/grpc/netty/shaded/(117 classes, via grpc-netty-shaded → Netty),io/opentelemetry/internal/shaded/(32 classes, via OpenTelemetry), andorg/apache/iceberg/gcp/shaded/(91 classes, Iceberg relocation of Netty). The old LICENSE only credited Netty. Not strictly required but improves accuracy.com/ctc/wstx/shaded/. Woodstox bundles four MSV artifacts (msv-core,xsdlib,isorelax,relaxngDatatype) and relocates them. Required: xsdlib and RELAX NG Datatype are BSD 3-Clause; isorelax is CDDL 1.1. Non-Apache licenses need full text in LICENSE.NOTICE
jackson-coreNOTICE references the shaded FastDoubleParser copy and its MIT copyright and includesCopyright 2007-, Tatu Saloranta (tatu.saloranta@iki.fi)but the old gcp-bundle NOTICE omitted it. Required: ASF policy mandates propagating upstream NOTICE contents.gcs-analytics-core-1.2.3.jarandclient-1.2.3.jarcontain noMETA-INF/NOTICEfile, so per ASF policy there is nothing to propagate. The previous entry appeared to be sourced from the project's GitHub README/license header rather than an actual NOTICE file. Not required: Only dependencies whose JARs contain a substantive (non-boilerplate) NOTICE file need an entry.