Skip to content

Azure: Fix LICENSE, NOTICE, and runtime-deps for azure-bundle#16181

Open
kevinjqliu wants to merge 4 commits intoapache:mainfrom
kevinjqliu:kevinjqliu/azure-bundle-license
Open

Azure: Fix LICENSE, NOTICE, and runtime-deps for azure-bundle#16181
kevinjqliu wants to merge 4 commits intoapache:mainfrom
kevinjqliu:kevinjqliu/azure-bundle-license

Conversation

@kevinjqliu
Copy link
Copy Markdown
Contributor

@kevinjqliu kevinjqliu commented Apr 30, 2026

Fixes license compliance gaps in azure-bundle found by auditing the shadow JAR contents against LICENSE/NOTICE declarations.
Exclude logging dependencies, following same pattern in #16105

Build and verify

./gradlew :iceberg-azure-bundle:shadowJar -x test
./gradlew :iceberg-azure-bundle:checkRuntimeDeps

LICENSE changes

  • Added FastDoubleParser (MIT)Required per Category B. Shaded into Jackson Core at org/apache/iceberg/azure/shaded/com/fasterxml/jackson/core/internal/shaded/fdp/ (52 class files). Full MIT text added.

    jar tf azure-bundle/build/libs/iceberg-azure-bundle-*.jar | grep -c "shaded/fdp"
    unzip -p azure-bundle/build/libs/iceberg-azure-bundle-*.jar META-INF/FastDoubleParser-NOTICE

    Upstream: https://github.com/wrandelshofer/FastDoubleParser/blob/main/LICENSE

  • Added fast_float (MIT)Required per Category B. Bundled transitively by FastDoubleParser.
    Upstream: https://github.com/fastfloat/fast_float/blob/main/LICENSE-MIT

  • Added bigint (BSD 2-Clause)Required per Category B. Bundled transitively by FastDoubleParser.
    Upstream: https://github.com/tbuktu/bigint/blob/master/LICENSE

  • Added MSAL4J Persistence Extension (MIT)Required per Category B. 61 classes at com/microsoft/aad/msal4jextensions/.

    jar tf azure-bundle/build/libs/iceberg-azure-bundle-*.jar | grep -c "msal4jextensions"

    Upstream: https://github.com/AzureAD/microsoft-authentication-library-for-java/blob/dev/LICENSE

  • Added Apache Tomcat Native / netty-tcnative (Apache 2.0) — Not strictly required (Apache-licensed) but consistent with existing convention of declaring all bundled components. 37 tcnative resources in JAR.

    jar tf azure-bundle/build/libs/iceberg-azure-bundle-*.jar | grep "tcnative"

    Upstream: https://tomcat.apache.org/native-doc/

  • Added Reactor Pool (Apache 2.0) — Consistent with convention. 35 classes at reactor/netty/internal/shaded/reactor/pool/.

    jar tf azure-bundle/build/libs/iceberg-azure-bundle-*.jar | grep -c "reactor/pool"
  • Replaced "Reactor AddOns" with "Aalto XML" (Apache 2.0) — Reactor AddOns (reactor-extra) is not present in the JAR (0 classes). Aalto XML is bundled by Azure SDK at com/azure/xml/implementation/aalto/ (72 classes).

    jar tf azure-bundle/build/libs/iceberg-azure-bundle-*.jar | grep -c "reactor/extra"
    jar tf azure-bundle/build/libs/iceberg-azure-bundle-*.jar | grep -c "aalto"

    Upstream: https://github.com/FasterXML/aalto-xml

  • Reactive Streams (MIT-0) — Corrected license label from MIT to MIT-0. The upstream POM declares <name>MIT-0</name> and source headers state "Licensed under MIT No Attribution (SPDX: MIT-0)". The license text already reflected MIT-0 (no attribution clause), but the License: label was inaccurate. Also removed redundant | MIT No Attribution header line from the quoted block since the license name is already conveyed by the License: MIT-0 label.
    Upstream POM: https://repo1.maven.org/maven2/org/reactivestreams/reactive-streams/1.0.4/reactive-streams-1.0.4.pom
    Upstream source: https://github.com/reactive-streams/reactive-streams-jvm/blob/master/LICENSE

NOTICE changes

  • Jackson — Added missing FastDoubleParser attribution section and missing copyright section. The upstream jackson-core NOTICE references the shaded FastDoubleParser copy and its MIT copyright and includes Copyright 2007-, Tatu Saloranta (tatu.saloranta@iki.fi) but the old gcp-bundle NOTICE omitted it. Required: ASF policy mandates propagating upstream NOTICE contents.
    jar tf azure-bundle/build/libs/iceberg-azure-bundle-*.jar | grep FastDoubleParser
    # Upstream NOTICE from Maven Central jackson-core-2.18.3.jar:
    curl -sL "https://repo1.maven.org/maven2/com/fasterxml/jackson/core/jackson-core/2.18.3/jackson-core-2.18.3.jar" -o /tmp/jc.jar && unzip -p /tmp/jc.jar META-INF/NOTICE

Copy link
Copy Markdown
Contributor

@aihuaxu aihuaxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kevinjqliu

@kevinjqliu kevinjqliu force-pushed the kevinjqliu/azure-bundle-license branch from f3b41ed to 1a1ebe7 Compare May 4, 2026 18:32
@kevinjqliu kevinjqliu marked this pull request as draft May 4, 2026 18:32
@kevinjqliu kevinjqliu changed the title Azure: Fix stale LICENSE entry Azure: Fix LICENSE, NOTICE, and runtime-deps for azure-bundle May 4, 2026
@kevinjqliu kevinjqliu marked this pull request as ready for review May 5, 2026 15:30
@kevinjqliu kevinjqliu added this to the Iceberg 1.11.0 milestone May 5, 2026
Comment thread azure-bundle/LICENSE Outdated
Comment thread azure-bundle/LICENSE Outdated
Comment thread azure-bundle/LICENSE Outdated
Comment thread azure-bundle/LICENSE Outdated
Comment thread azure-bundle/LICENSE Outdated
Comment thread azure-bundle/LICENSE Outdated
Comment thread azure-bundle/LICENSE Outdated
kevinjqliu and others added 3 commits May 5, 2026 17:15
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Comment thread azure-bundle/LICENSE
Comment on lines -210 to -211
| The MIT License (MIT)
|
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

formatting issue, align with the rest of the file

Comment thread azure-bundle/LICENSE
Comment on lines -248 to -253
| MIT License
|
| Copyright (c) Microsoft Corporation. All rights reserved.
|
| Permission is hereby granted, free of charge, to any person obtaining a copy
| of this software and associated documentation files (the "Software"), to deal
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

formatting issue, remove the redundant MIT License, added a new line, and realign the rest of the lines

@kevinjqliu kevinjqliu requested review from rdblue and stevenzwu May 6, 2026 00:24
@kevinjqliu
Copy link
Copy Markdown
Contributor Author

thanks for the reviews, i applied the formatting fixes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants