GCP: Add CloudMonitoringMetricsReporter to export Iceberg metrics to Cloud Monitoring#16107
Open
talatuyarer wants to merge 3 commits intoapache:mainfrom
Open
GCP: Add CloudMonitoringMetricsReporter to export Iceberg metrics to Cloud Monitoring#16107talatuyarer wants to merge 3 commits intoapache:mainfrom
talatuyarer wants to merge 3 commits intoapache:mainfrom
Conversation
60316ce to
fc34a15
Compare
stevenzwu
reviewed
Apr 30, 2026
| implementation "com.google.cloud:google-cloud-bigquery" | ||
| implementation "com.google.cloud:google-cloud-core" | ||
| implementation "com.google.cloud:google-cloud-kms" | ||
| implementation "com.google.cloud:google-cloud-monitoring" |
Contributor
There was a problem hiding this comment.
we should be very careful with dependency change for runtime bundle jar. was this PR created after all the dependency/license fixes. at least, rebase with the latest main branch. CI should catch dependency/license problems nowadays.
Contributor
Author
There was a problem hiding this comment.
Yes I created this PR Last Friday. How can I verify that ? There is also license check too
https://github.com/apache/iceberg/actions/runs/25008117162/job/73236359466?pr=16107
…e Cloud Monitoring modified: gcp/src/integration/java/org/apache/iceberg/gcp/metrics/TestCloudMonitoringMetricsReporterIntegration.java modified: gcp/src/main/java/org/apache/iceberg/gcp/metrics/CloudMonitoringMetricsReporter.java modified: gcp/src/test/java/org/apache/iceberg/gcp/metrics/TestCloudMonitoringMetricsReporter.java
…sses modified: gcp/src/integration/java/org/apache/iceberg/gcp/metrics/TestCloudMonitoringMetricsReporterIntegration.java modified: gcp/src/main/java/org/apache/iceberg/gcp/metrics/CloudMonitoringMetricsReporter.java modified: gcp/src/test/java/org/apache/iceberg/gcp/metrics/TestCloudMonitoringMetricsReporter.java
c94ffc9 to
3a062b4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new MetricsReporter implementation to the iceberg-gcp module that sends Iceberg scan and commit metrics to Google Cloud Monitoring.