Rename RestContext to RestClient - #2994
Merged
Merged
Conversation
DerGut
marked this pull request as ready for review
August 13, 2026 18:31
CTTY
reviewed
Aug 13, 2026
CTTY
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the quick PR and it LGTM!
Do you mind addressing the recently merged auth_session naming in client.rs and catalog.rs here as well?
example:
We should also to use with_auth_session here:
I think renaming these can help us avoid confusion in the following development
Re-generate public API
Contributor
Author
Good point! I've pushed another commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Following from #2920 (comment)
This is a rename to resolve a naming conflict between the previous
RestContextandSessionContextin the same scope. Both overlapping in variables namescontext.What changes are included in this PR?
RestContexttoRestClientcontexttoclientRestCatalog::contexttoRestCatalog::clientHttpClientfromclienttohttp_clientAre these changes tested?
Via the compiler and the same test suite. No functional changes.
AI Disclosure
None 😱