feat: Derive TableProperties parsing - #2988
Open
blackmwk wants to merge 1 commit into
Open
Conversation
This was referenced Aug 12, 2026
blackmwk
force-pushed
the
ir-2877-table-properties-derive
branch
2 times, most recently
from
August 12, 2026 03:37
e8d8b3d to
c4ee623
Compare
Port the existing TableProperties keys, defaults, and custom parsers to the Properties derive macro while preserving the TryFrom API and public fields for compatibility. Add generated getters and update the public API snapshot.\n\nCloses #2968.
blackmwk
force-pushed
the
ir-2877-table-properties-derive
branch
from
August 12, 2026 17:44
c4ee623 to
7753545
Compare
CTTY
reviewed
Aug 12, 2026
CTTY
left a comment
Collaborator
There was a problem hiding this comment.
LGTM! left one minor comment
| ErrorKind::DataInvalid, | ||
| format!( | ||
| "Invalid value for {}: path must not be empty", | ||
| TableProperties::PROPERTY_WRITE_METADATA_PATH |
Collaborator
There was a problem hiding this comment.
I think we should not hardcode this. Some other location properties like write_object_storage_location could reuse this but they didn't do so. we should fix it
Collaborator
|
My AI flagged something interesting as well:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
TablePropertieskeys, defaults, and custom parsers to#[derive(Properties)].TryFrom<&HashMap<String, String>>behavior and public fields so this layer remains source-compatible.from_propertiesconstructor.This is the middle PR in stack #2990. It depends on #2987; #2989 migrates consumers and makes the backing fields private.
Are these changes tested?
cargo test -p iceberg spec::table_propertiescargo public-api -p iceberg --all-features -ssAI Disclosure
This change was implemented and validated with OpenAI Codex assistance.