fix: update release workflow to publish to PyPI in the same workflow instead of workflow call#2715
Open
dannycjones wants to merge 1 commit into
Open
fix: update release workflow to publish to PyPI in the same workflow instead of workflow call#2715dannycjones wants to merge 1 commit into
dannycjones wants to merge 1 commit into
Conversation
…instead of workflow call
Contributor
Author
|
FYI @kevinjqliu @CTTY I'm hoping this is a mid-term fix for the PyPI trusted publishing. We're unblocked for 0.10.0-rc1 but for later releases, I'm hoping this simplifies things. If not, I think we need an update to the release guide to specifically call out the need for manual workflow dispatch to complete the PyPI RC publish. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
This change moves PyPI publishing into the
publish.ymltop-level workflow. The original Python release workflow instead is used for packaging only, and the artifacts are downloaded and published bypublish.yml.The existing workarounds are maintained for now, where committers can manually invoke the workflow to publish Python package artifacts.
In order to use this change, we must allow PyPI to additionally authenticate with `publish.yml. Instructions on how to add new publishers: https://docs.pypi.org/trusted-publishers/adding-a-publisher/
Are these changes tested?
No. I did not find a good way to dry-run test the workflow, so I do not have any PyPI equivalent to this: #2705