feat(sqllogictest): Support configuring datafusion catalog in sqllogic…#2132
Closed
charlesdong1991 wants to merge 1 commit intoapache:mainfrom
Closed
feat(sqllogictest): Support configuring datafusion catalog in sqllogic…#2132charlesdong1991 wants to merge 1 commit intoapache:mainfrom
charlesdong1991 wants to merge 1 commit intoapache:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
Changes:
Added "memory" catalog to iceberg-catalog-loader
Added MemoryCatalogBuilder to the catalog registry
Added test for memory catalog loading
Updated DataFusionEngine to use dynamic catalog loading
Not sure if we want to have a default memory catalog is still used when no config is provided for backward compatible purpose
Are these changes tested?
Yes, tests have passed locally.