Skip to content

Add catalog test suite to unify catalog's behavior.#2131

Open
blackmwk wants to merge 7 commits intoapache:mainfrom
blackmwk:2086
Open

Add catalog test suite to unify catalog's behavior.#2131
blackmwk wants to merge 7 commits intoapache:mainfrom
blackmwk:2086

Conversation

@blackmwk
Copy link
Contributor

Which issue does this PR close?

What changes are included in this PR?

In this pr we introduced catalog test suite in catalog-loader, which could unify the behavior of catalogs.

Are these changes tested?

Yes.

@blackmwk blackmwk requested review from CTTY, kevinjqliu and sdd and removed request for kevinjqliu February 10, 2026 03:35
@blackmwk blackmwk assigned Fokko and Xuanwo and unassigned Fokko and Xuanwo Feb 10, 2026
@blackmwk blackmwk requested review from Fokko and Xuanwo February 10, 2026 03:35
Copy link
Collaborator

@CTTY CTTY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @blackmwk for the PR! This makes the test code much easier to manage.

Just finished a round of review and left some comments

let metadata_location = root_namespace_state.remove_existing_table(table_ident)?;
self.file_io.delete(&metadata_location).await
root_namespace_state.remove_existing_table(table_ident)?;
Ok(())
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realized we don't have a catalog API to purge table in iceberg-rust?

Probably need to add this API to better define the expected behavior

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created an issue to track this: #2133

I can work on it once this PR is merged

Copy link
Collaborator

@CTTY CTTY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unified catalog test suite.

4 participants