Skip to content

feat: puffin Reader and Writer#676

Merged
zeroshade merged 9 commits intoapache:mainfrom
Shreyas220:feat/puffin
Feb 24, 2026
Merged

feat: puffin Reader and Writer#676
zeroshade merged 9 commits intoapache:mainfrom
Shreyas220:feat/puffin

Conversation

@Shreyas220
Copy link
Copy Markdown
Contributor

@Shreyas220 Shreyas220 commented Jan 12, 2026 •
edited
Loading

for #589

  • Added PuffinWriter
  • Added PuffinReader
  • uncompressed only

@Shreyas220
feat: init puffin
744bf10 
Signed-off-by: Shreyas220 <shreyas.ny@gmail.com>
@Shreyas220
feat: puffin writer
7f9c6d0 
Signed-off-by: Shreyas220 <shreyas.ny@gmail.com>
@Shreyas220
feat: puffin reader
87c2634 
Signed-off-by: Shreyas220 <shreyas.ny@gmail.com>
@Shreyas220
chore: lint fix
e563a73 
Signed-off-by: Shreyas220 <shreyas.ny@gmail.com>
@Shreyas220
Copy link
Copy Markdown
Contributor Author

Shreyas220 commented Jan 12, 2026 •
edited
Loading

Hey 👋 @zeroshade , @twuebi would appreciate a review
tests coming next

@Shreyas220 Shreyas220 marked this pull request as ready for review January 12, 2026 22:54
zeroshade
zeroshade requested changes Jan 13, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@zeroshade zeroshade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for starting this up! I've been wanting to get a puffin reader/writer in here for a while now. I've gone through with a bunch of questions / requests etc. But this also needs to have some tests and potentially examples if possible!

Thanks again!

Comment thread puffin/puffin.go
Comment thread puffin/puffin.go Outdated
Comment thread puffin/puffin_writer.go
Comment thread puffin/puffin_writer.go Outdated
Comment thread puffin/puffin_writer.go
Comment thread puffin/puffin_reader.go Outdated
Comment thread puffin/puffin_reader.go Outdated
Comment thread puffin/puffin_reader.go Outdated
Comment thread puffin/puffin_reader.go Outdated
Comment thread puffin/puffin_reader.go Outdated
@Shreyas220
chore: hanlding review changes
1aa0e7a 
Signed-off-by: Shreyas220 <shreyas.ny@gmail.com>
@Shreyas220
chore: adding test
91c2a6a 
Signed-off-by: Shreyas220 <shreyas.ny@gmail.com>
@Shreyas220
feat: fmt + review comments + tests
3e3ea83 
Signed-off-by: Shreyas220 <shreyas.ny@gmail.com>
@Shreyas220 Shreyas220 requested a review from zeroshade January 19, 2026 19:51
zeroshade
zeroshade reviewed Jan 26, 2026
View reviewed changes
Comment thread puffin/puffin_reader.go Outdated
zeroshade
zeroshade reviewed Jan 26, 2026
View reviewed changes
Comment thread puffin/puffin_reader.go Outdated
zeroshade
zeroshade requested changes Jan 26, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@zeroshade zeroshade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few remaining comments and then this looks good to me!

Is there any testing repository of existing, known-valid Puffin files that we could create an integration test with?

@subkanthi
Copy link
Copy Markdown
Contributor

subkanthi commented Feb 7, 2026

Eagerly waiting for this to add compression support, @Shreyas220 happy to help.

@Shreyas220
chore(puffin): review refactor
5f898e6 
Signed-off-by: Shreyas220 <shreyas.ny@gmail.com>
@github-actions github-actions Bot added the INFRA label Feb 18, 2026
@zeroshade
Copy link
Copy Markdown
Member

zeroshade commented Feb 19, 2026

Thanks for adding the tests @Shreyas220 can we add a comment in the file saying where the testdata files came from?

Also my previous two comments still need a response. Otherwise this looks good!

@Shreyas220
test(puffin): Java puffin file fixture tests
8bb1ac8 
Signed-off-by: Shreyas220 <shreyas.ny@gmail.com>
@Shreyas220
Copy link
Copy Markdown
Contributor Author

Shreyas220 commented Feb 21, 2026 •
edited
Loading

@zeroshade resolved the last 2 comments and added a readme in testdata and a comment above the tests in puffin_test.go readFixture test to point to that exact location we got the puffin files from

zeroshade
zeroshade approved these changes Feb 23, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@zeroshade zeroshade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one nitpick to address and I'll merge

Comment thread dev/release/rat_exclude_files.txt
@zeroshade zeroshade merged commit 19bec10 into apache:main Feb 24, 2026
13 checks passed
rockwotj pushed a commit to rockwotj/iceberg-go that referenced this pull request Mar 18, 2026
@Shreyas220 @rockwotj
feat: puffin Reader and Writer (apache#676)
cb0c799 
for apache#589

  - Added PuffinWriter 
  - Added PuffinReader 
  -  uncompressed only

---------

Signed-off-by: Shreyas220 <shreyas.ny@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zeroshade zeroshade zeroshade approved these changes

Assignees

No one assigned

Labels

INFRA

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Shreyas220 @subkanthi @zeroshade