feat: add json serde for expression operations #532
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evindj
changed the title
evindj
changed the title
wgtmac
reviewed
Jan 27, 2026
wgtmac
reviewed
Jan 28, 2026
Member
wgtmac
left a comment
wgtmac
left a comment
There was a problem hiding this comment.
I just finished another round of review. Let me know what you think. Thanks!
BTW, could you please use conventional commit message to be consistent with this project?
wgtmac
reviewed
Jan 28, 2026
evindj
force-pushed
the
bool_expressio_serde
branch
5 times, most recently
from
940eace to
cfac526
Compare
Member
|
Thanks for the update! Let me know when ready to review again. |
evindj
changed the title
Contributor
Author
|
@wgtmac I think this ok to have another look. |
wgtmac
approved these changes
Jan 31, 2026
Member
wgtmac
left a comment
wgtmac
left a comment
There was a problem hiding this comment.
Overall looks good to me. I left some minor comments. Thanks for consolidating the PR!
evindj
force-pushed
the
bool_expressio_serde
branch
2 times, most recently
from
745c0ba to
a901428
Compare
wgtmac
approved these changes
Jan 31, 2026
Member
wgtmac
left a comment
wgtmac
left a comment
There was a problem hiding this comment.
Thanks for the quick update. I just found a minor question.
evindj
force-pushed
the
bool_expressio_serde
branch
from
a901428 to
3101ffc
Compare
wgtmac
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is the first PR aimed a addressing #331
Because doing it in one go will be more error prone and will make review harder, I am splitting the change across several PR.
This first one covers:
Test
Running main() from gmock_main.cc
Note: Google Test filter = ExpressionJson*
[==========] Running 2 tests from 1 test suite.
[----------] Global test environment set-up.
[----------] 2 tests from ExpressionJsonTest
[ RUN ] ExpressionJsonTest.CheckBooleanExpression
[ OK ] ExpressionJsonTest.CheckBooleanExpression (0 ms)
[ RUN ] ExpressionJsonTest.OperationTypeTests
[ OK ] ExpressionJsonTest.OperationTypeTests (0 ms)
[----------] 2 tests from ExpressionJsonTest (0 ms total)
[----------] Global test environment tear-down
[==========] 2 tests from 1 test suite ran. (0 ms total)
[ PASSED ] 2 tests.
idjiofack@Innocents-MacBook-Pro-2 ~/Documents/my_iceberg/iceberg-cpp bool_expressio_serde