Skip to content

feat: Add script to build and push Docker images - #14101

Closed
deepakpanda93 wants to merge 4 commits into
apache:masterfrom
deepakpanda93:br_docker_image_build_push
Closed

feat: Add script to build and push Docker images#14101
deepakpanda93 wants to merge 4 commits into
apache:masterfrom
deepakpanda93:br_docker_image_build_push

Conversation

@deepakpanda93

Copy link
Copy Markdown
Collaborator

Describe the issue this Pull Request addresses

This PR introduces a script to streamline the process of building and pushing Docker images.

Summary and Changelog

This PR adds shell scripts that:

  • Builds a Docker image using a specified Dockerfile.
  • Pushes the tagged image(s) to a specified Docker registry.

Impact

None

Risk Level

none

Documentation Update

Script includes inline comments and usage help. No updates needed on the Hudi website.

Contributor's checklist

  • Read through contributor's guide
  • Enough context is provided in the sections above
  • Adequate tests were added if applicable

@github-actions github-actions Bot added the size:S PR with lines of changes in (10, 100] label Oct 16, 2025
@deepakpanda93
deepakpanda93 marked this pull request as ready for review October 16, 2025 18:38
Comment thread docker/push_docker_images.sh Outdated
@github-actions github-actions Bot added size:M PR with lines of changes in (100, 300] and removed size:S PR with lines of changes in (10, 100] labels Oct 28, 2025
@hudi-bot

Copy link
Copy Markdown
Collaborator

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

set -e

# -----------------------------------------------------------------------------
# build_and_push_docker_images.sh

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add more descriptions here, describe what this script does, and who should use it (as in pushing is for hudi maintainers, not every users)

#
# Example:
# ./build_and_push_docker_images.sh # build only
# ./build_and_push_docker_images.sh true # build and push

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# ./build_and_push_docker_images.sh true # build and push
# ./build_and_push_docker_images.sh --publish true # build and publish

rename to call it publish? and use named arg to be explicit

@yihua yihua left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deepakpanda93 could you address the comments?

@deepakpanda93

Copy link
Copy Markdown
Collaborator Author

Closing in favour of #19489.

docker/build_docker_images.sh was substantially rewritten on master after this PR was opened, and this PR replaces that file with a copy forked from the older version. Rebasing would therefore have reverted the named version flags, the pom.xml-derived version tag, the Java 11/17 base selection and the multi-arch support that landed since. #19489 is a fresh port of the same idea onto the current script instead.

Both review comments here are addressed there:

  • merged into a single script rather than a second one, with --publish <true|false> defaulting to false
  • the header describes what the script does and that publishing is for maintainers, reachable via --help
  • the flag is named --publish and takes an explicit value, as suggested

Thanks @xushiyan for the review, and @yihua for the nudge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M PR with lines of changes in (100, 300]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants