feat: Add script to build and push Docker images - #14101
Conversation
| set -e | ||
|
|
||
| # ----------------------------------------------------------------------------- | ||
| # build_and_push_docker_images.sh |
There was a problem hiding this comment.
add more descriptions here, describe what this script does, and who should use it (as in pushing is for hudi maintainers, not every users)
| # | ||
| # Example: | ||
| # ./build_and_push_docker_images.sh # build only | ||
| # ./build_and_push_docker_images.sh true # build and push |
There was a problem hiding this comment.
| # ./build_and_push_docker_images.sh true # build and push | |
| # ./build_and_push_docker_images.sh --publish true # build and publish |
rename to call it publish? and use named arg to be explicit
yihua
left a comment
There was a problem hiding this comment.
@deepakpanda93 could you address the comments?
|
Closing in favour of #19489.
Both review comments here are addressed there:
|
Describe the issue this Pull Request addresses
This PR introduces a script to streamline the process of building and pushing Docker images.
Summary and Changelog
This PR adds shell scripts that:
Impact
None
Risk Level
none
Documentation Update
Script includes inline comments and usage help. No updates needed on the Hudi website.
Contributor's checklist