Fix resource leaking on error in AsyncCachingExec - #871
Merged
ok2c merged 1 commit intoAug 14, 2026
Conversation
Member
|
@Jouramie cherry-picked to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
dataConsumer.consumethrows, the resources allocated by the consumer are never released. This causes a memory leak, especially with zstd, sinceZstdDecompressCtxallocates native memory in itsinitthat must be freed explicitly.Trace found while investigating the leak:
This mostly happens when requests are cancelled, which causes
consume()to throw.The fix wraps the returned
AsyncDataConsumersoreleaseResources()is always called ifconsume()throws, sinceAsyncCachingExec.triggerResponsedoesn't do this itself.