HIVE-29768: Fix ClassNotFoundException(SQLStdHiveAuthorizerFactoryForTest) in compactor tests

[maheshrajus]

What changes were proposed in this pull request?

Disables hive.compactor.gather.stats by default in the compactor test base class (CompactorTest)
so post-compaction stats gathering no longer runs during unit tests.
These tests do not assert on the stats that StatsUpdater.gatherStats produces.

Why are the changes needed?

Every TestWorker run (and every other test extending CompactorTest) emits a loud stack trace(CNFE) after each successful compaction.

  ERROR session.SessionState: Error setting up authorization:                                       
    java.lang.ClassNotFoundException:                                                                                                                                                 
  org.apache.hadoop.hive.ql.security.authorization.plugin.sqlstd.SQLStdHiveAuthorizerFactoryForTest 

Does this PR introduce any user-facing change?

No

How was this patch tested?

Existed UT

[maheshrajus]

@abstractdog @ayushtkn @deniskuzZ @zabetak Could you please review and approve the changes at your convenience?
Thank you!

[uros-b]

LGTM

[abstractdog]

@abstractdog @ayushtkn @deniskuzZ @zabetak Could you please review and approve the changes at your convenience? Thank you!

the fix makes sense to me: let's not gather stats if the compactor tests don't rely on them, can make this comment more concise?

   //Post-compaction stats gathering runs an ANALYZE TABLE query through the Driver,
    // which triggers SessionState.setupAuth() and fails here with a ClassNotFoundException:
    // data/conf/hive-site.xml points hive.security.authorization.manager at
    // SQLStdHiveAuthorizerFactoryForTest, but that class lives in itests/util which
    // isn't on the ql test classpath. StatsUpdater swallows the failure so tests still pass.
    // Disable stats by default as these tests do not assert on the stats that StatsUpdater.gatherStats produces.

Later readers are not interested in this detail; they need to know the basic facts like: "Disable stats by default as these tests do not assert on the stats that StatsUpdater.gatherStats produces." you can also add a minor note that, enabling these would need a proper setup of an authorizer

[maheshrajus]

the fix makes sense to me: let's not gather stats if the compactor tests don't rely on them, can make this comment more concise?

   //Post-compaction stats gathering runs an ANALYZE TABLE query through the Driver,
    // which triggers SessionState.setupAuth() and fails here with a ClassNotFoundException:
    // data/conf/hive-site.xml points hive.security.authorization.manager at
    // SQLStdHiveAuthorizerFactoryForTest, but that class lives in itests/util which
    // isn't on the ql test classpath. StatsUpdater swallows the failure so tests still pass.
    // Disable stats by default as these tests do not assert on the stats that StatsUpdater.gatherStats produces.

Later readers are not interested in this detail; they need to know the basic facts like: "Disable stats by default as these tests do not assert on the stats that StatsUpdater.gatherStats produces." you can also add a minor note that, enabling these would need a proper setup of an authorizer

@abstractdog Fixed

[mdayakar]

LGTM

[sonarqubecloud]

Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud