HIVE-28400: Refactor QueryProperties feature flags to use QueryFeature enum#6560
Open
Manya0407 wants to merge 1 commit into
Open
HIVE-28400: Refactor QueryProperties feature flags to use QueryFeature enum#6560Manya0407 wants to merge 1 commit into
Manya0407 wants to merge 1 commit into
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What changes were proposed in this pull request?
1.This PR refactors
QueryPropertiesfeature tracking from multiple boolean fields to an enum-based model.2.Query feature flags such as
GROUP_BY,ORDER_BY,LIMIT,PTF,WINDOWING,QUALIFY,EXCEPT,INTERSECT,USES_SCRIPT, and related clause flags are now represented byQueryFeaturevalues stored in anEnumSet<QueryFeature>.3.Relevant feature writer and reader call sites were updated to use
addFeature(QueryFeature.X)andhasFeature(QueryFeature.X).4.Compatibility wrapper methods such as
hasGroupBy()andsetHasGroupBy(boolean)continue to delegate to the enum-backed storage. Non-feature state such as join counts, query type, lateral view flags, view/materialized view flags, analyze flags, and used tables remains unchanged.Why are the changes needed?
The previous implementation stored query features as many individual boolean fields, which made
QueryPropertiesharder to read and extend.Using aQueryFeatureenum withEnumSetkeeps related feature state in one place, reduces repeated boolean field management, and makes adding future query features simpler and less error-prone.EnumSetis also efficient for enum values and is a good fit for representing query features.Does this PR introduce any user-facing change?
No
How was this patch tested?
Manual testing