Hive-29660: Show an Apache Hive banner on Beeline startup#6539
Open
aturoczy wants to merge 7 commits into
Open
Hive-29660: Show an Apache Hive banner on Beeline startup#6539aturoczy wants to merge 7 commits into
aturoczy wants to merge 7 commits into
Conversation
asf-ci-hive
added
tests pending
tests unstable
and removed
tests failed
tests pending
labels
|
difin
reviewed
Jun 22, 2026
| .toString(); | ||
| } | ||
|
|
||
|
|
Contributor
There was a problem hiding this comment.
There are two empty lines here, please make only one empty line.
difin
reviewed
Jun 22, 2026
Comment on lines
-127
to
-142
| /** | ||
| * A console SQL shell with command completion. | ||
| * <p> | ||
| * TODO: | ||
| * <ul> | ||
| * <li>User-friendly connection prompts</li> | ||
| * <li>Page results</li> | ||
| * <li>Handle binary data (blob fields)</li> | ||
| * <li>Implement command aliases</li> | ||
| * <li>Stored procedure execution</li> | ||
| * <li>Binding parameters to prepared statements</li> | ||
| * <li>Scripting language</li> | ||
| * <li>XA transactions</li> | ||
| * </ul> | ||
| * | ||
| */ |
Contributor
There was a problem hiding this comment.
Why should these TODO items be removed?
Author
There was a problem hiding this comment.
I will create follow-up JIRA tickets for these items, or at least for the ones that make sense to follow up on.
For example, I am not sure what “scripting language” or “SP execution” means in this context. SP execution is already possible, so that part may need clarification before creating a separate ticket.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Show an Apache Hive banner on Beeline startup
Does this PR introduce any user-facing change?
Yes, when the user starts Beeline, it elegantly display the Hive version and show a Hive banner. Same as above screenshot
How was this patch tested?
Manually tested.