[WIP]

[dengzhhu653]

What changes were proposed in this pull request?

Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?

[Copilot]

Pull request overview

This PR appears to refactor the standalone metastore RawStore into pluggable sub-stores (e.g., TableStore, PrivilegeStore, NotificationStore) wired via a new @MetaDescriptor + unwrap() mechanism, with transaction/query lifecycle managed by proxy/handlers. It also updates tests/utilities to use the new store interfaces and improves a few test/metadata details (e.g., catalog name in stats).

Changes:

• Introduces MetaDescriptor-based store unwrapping plus transactional proxying (TransactionHandler, RawStoreAware, PersistenceManagerProxy).
• Adds new store interfaces + implementations for table/privilege/notification operations and migrates RawStore APIs to default delegations.
• Updates several tests and utilities to use TableStore and a new DirectSqlConfigurator helper.

Reviewed changes

Copilot reviewed 20 out of 23 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/utils/DirectSqlConfigurator.java	New test helper to toggle TRY_DIRECT_SQL and assert no unexpected direct SQL errors.
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/client/TestAlterPartitions.java	Updates expected exception types for rename-partition negative tests.
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/VerifyingObjectStore.java	Refactors verification paths to use TableStore + config toggling rather than internal SQL/ORM helpers.
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestObjectStore.java	Migrates tests to TableStore APIs and adds TRY_DIRECT_SQL toggling scopes.
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java	Removes unused imports.
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/StatisticsTestUtils.java	Ensures ColumnStatisticsDesc includes catalog name.
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/metastore/impl/PrivilegeStoreImpl.java	New privilege store implementation separated from RawStore.
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/metastore/impl/NotificationStoreImpl.java	New notification store implementation separated from RawStore.
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/metastore/iface/TableStore.java	New interface defining table/partition-related store APIs.
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/metastore/iface/PrivilegeStore.java	New interface defining privilege/role store APIs.
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/metastore/iface/NotificationStore.java	New interface defining notification event store APIs.
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/metastore/TransactionHandler.java	Dynamic-proxy invocation handler that opens/commits/rolls back transactions and closes tracked queries.
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/metastore/RawStoreAware.java	Base class to inject RawStore and PersistenceManager into store implementations.
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/metastore/PersistenceManagerProxy.java	Proxy wrapper to track opened queries and expose execution context via an auxiliary interface.
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/metastore/MetaDescriptor.java	New annotation used to discover store aliases and transactional behavior.
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/metastore/GetListHelper.java	New helper specialization for list-returning GetHelper use cases.
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/metastore/GetHelper.java	New transaction-aware SQL-vs-ORM helper with direct SQL fallback behavior.
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/directsql/MetastoreDirectSqlUtils.java	Adjusts execution-context access to support proxied PersistenceManager.
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java	Removes/adjusts delegations in favor of new store unwrapping and adds missing database model import.
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/RawStore.java	Converts many APIs to default methods delegating to unwrap()ed stores; adds unwrap(Class<T>).
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java	Moves partition-existence check earlier in alter-partition flow.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

In the COLUMN case, this asserts objToRefresh.getColumnName() == null, but HiveObjectRef.columnName is a required thrift field and callers (e.g., PrivilegeHandler) pass an actual column name. This will cause refresh_privileges to fail for column objects. Also, the code fetches all column grants for the table; it should load only the relevant column/partition-column grants based on objToRefresh (columnName + optional partValues).

[sonarqubecloud]

Quality Gate passed

Issues
553 New issues
0 Accepted issues

Measures
5 Security Hotspots
0.0% Coverage on New Code
2.1% Duplication on New Code

See analysis details on SonarQube Cloud