HIVE-29563: Iceberg REST Catalog's error logs are too verbose

[okumin]

What changes were proposed in this pull request?

Stop logging every client-side error, i.e., 40x errors.

https://issues.apache.org/jira/browse/HIVE-29563

Why are the changes needed?

As explained in HIVE-29563, the current REST API prints the entire stack trace on every error.

apache/iceberg has the same problem and sent a patch, but it has not been reviewed: apache/iceberg#14908

Does this PR introduce any user-facing change?

It includes a change for HMS administrators.

How was this patch tested?

standalone-metastore/packaging/src/docker/build.sh -repo local
docker run --rm --name hive-standalone-metastore \
  -p 9083:9083 \
  -p 9001:9001 \
  local/hive:standalone-metastore-4.3.0-SNAPSHOT
curl -i http://localhost:9001/iceberg/v1/namespaces/default/tables/does_not_exist

[okumin]

RESTServerCatalogAdapter on apache/iceberg extends a RESTClient. I don't know the exact reason. The trick is used in some integration tests.
Anyway, as our adapter never behaves as a client, I removed the dependency on RESTClient. As a good side effect, this change ensures only a single path invokes RESTServerCatalogAdapter#execute and allows us to simplify the implementation.

[ayushtkn]

@henrib can you check once

[henrib]

If this does not require any test changes, LGTM 👍

[henrib]

May be also reduce exception verbosity:

  public static void configureResponseFromException(
      Exception exc, ErrorResponse.Builder errorBuilder) {
    int errorCode = EXCEPTION_ERROR_CODES.getOrDefault(exc.getClass(), 500);
    errorBuilder
        .responseCode(errorCode)
        .withType(exc.getClass().getSimpleName())
        .withMessage(exc.getMessage());
    // avoid exposing stack traces for client errors, but include them for server errors to aid debugging
    if (errorCode == 500) {
      errorBuilder.withStackTrace(exc);
    }
  }

[okumin]

Is this aligned with you?
7039752

[henrib]

Yes :-)

[okumin]

Thanks for your review! It will make upcoming changes easy to review

[okumin]

Is this aligned with you?
7039752

[ayushtkn]

LGTM

[okumin]

I merged the master branch and resolved conflicts.

Additionally, I found that we can't see anything when a 5xx error occurs. I updated it so we can see a similar log on server errors, and INFO log for non-server errors for convenience.

2026-05-06T04:41:44,152  INFO [qtp1381730594-59] rest.HMSCatalogAdapter: A client error happened while processing REST request: Table does not exist: default.does_not_exist

[sonarqubecloud]

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud