HIVE-29534: getColStatistics to use HMS NDV values for DATE/TIMESTAMP column types#6406
Open
konstantinb wants to merge 3 commits intoapache:masterfrom
Open
HIVE-29534: getColStatistics to use HMS NDV values for DATE/TIMESTAMP column types#6406konstantinb wants to merge 3 commits intoapache:masterfrom
konstantinb wants to merge 3 commits intoapache:masterfrom
Conversation
konstantinb
changed the title
zabetak
reviewed
Apr 3, 2026
Member
zabetak
left a comment
zabetak
left a comment
There was a problem hiding this comment.
I am fully supportive of this change. Even though it leads to many .q.out changes not having NDV for DATE/TIMESTAMP columns is a genuine bug that requires a fix. In its current state, some .q.out files seem to be a bit messed up but once you get a clean run with all .q.out correctly updated I will approve the PR.
|
Contributor
Author
|
I needed to rebase the branch and regenerate JSON .out files. All tests pass now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
HIVE-29534: getColStatistics to use HMS NDV values forDATE/TIMESTAMP column types
Why are the changes needed?
Using statistics info for these fields when available could improve query planning/performance
Does this PR introduce any user-facing change?
No
How was this patch tested?
reviewed impacted .out files