Skip to content

HIVE-29413: Avoid code duplication by updating getPartCols method for iceberg tables#6337

Open
ramitg254 wants to merge 1 commit intoapache:masterfrom
ramitg254:HIVE-29413
Open

HIVE-29413: Avoid code duplication by updating getPartCols method for iceberg tables#6337
ramitg254 wants to merge 1 commit intoapache:masterfrom
ramitg254:HIVE-29413

Conversation

@ramitg254
Copy link
Contributor

@ramitg254 ramitg254 commented Feb 24, 2026

What changes were proposed in this pull request?

updated getPartCols method and introduced a boolean parameter in it to handle partition keys needed for non native tables and to get rid of this kind of code redundancy in some places:

table.hasNonNativePartitionSupport() ?
            table.getStorageHandler().getPartitionKeys(table) :
            table.getPartCols();

Why are the changes needed?

to avoid code redundancy and have a common method to retrieve keys for both native and non native tables.

Does this PR introduce any user-facing change?

No

How was this patch tested?

locally

@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants