HIVE-29455: Normalize Java license headers, part 2 - license source line#6313
Open
okumin wants to merge 3 commits intoapache:masterfrom
Open
HIVE-29455: Normalize Java license headers, part 2 - license source line#6313okumin wants to merge 3 commits intoapache:masterfrom
okumin wants to merge 3 commits intoapache:masterfrom
Conversation
find . -path "./iceberg" -prune -o -type f -name "*.java" -print0 | \
while IFS= read -r -d '' file; do
perl -i -pe '
if ($. <= 11 && m{^ \* +http://www\.apache\.org/licenses/LICENSE-2\.0\n$} && !m{^ \* {5}http://www\.apache\.org/licenses/LICENSE-2\.0\n$}) {
$_ = " * http://www.apache.org/licenses/LICENSE-2.0\n";
}
' "$file"
done
16e249f to
22c6399
Compare
|
Contributor
Author
|
@difin PTAL when you have a chance. Please read |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What changes were proposed in this pull request?
Align headers with asf.header.
Why are the changes needed?
Our quality gates report a non-obvious error when a new file has a non-aligned header. See also the following ticket.
https://issues.apache.org/jira/browse/HIVE-29455
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Put the following
checkstyle/checkstyle.xml, and then ranmvn checkstyle:check.Review instruction
This PR includes three changes.
You can reproduce the second commit with the following command.
This PR changes mostly only whitespaces, so you can use the
-woption to make your review easier.