-
Notifications
You must be signed in to change notification settings - Fork 4.8k
HIVE-29409: Async request fails to retry on transparent exceptions #6284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
211 changes: 211 additions & 0 deletions
211
...e-server/src/test/java/org/apache/hadoop/hive/metastore/handler/TestRetryOnException.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,211 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.hadoop.hive.metastore.handler; | ||
|
|
||
| import java.nio.file.Paths; | ||
| import java.util.HashMap; | ||
| import java.util.Map; | ||
|
|
||
| import org.apache.hadoop.conf.Configuration; | ||
| import org.apache.hadoop.fs.Path; | ||
| import org.apache.hadoop.hive.common.TableName; | ||
| import org.apache.hadoop.hive.metastore.HiveMetaStoreClient; | ||
| import org.apache.hadoop.hive.metastore.TableType; | ||
| import org.apache.hadoop.hive.metastore.TransactionalMetaStoreEventListener; | ||
| import org.apache.hadoop.hive.metastore.annotation.MetastoreCheckinTest; | ||
| import org.apache.hadoop.hive.metastore.api.MetaException; | ||
| import org.apache.hadoop.hive.metastore.api.NoSuchObjectException; | ||
| import org.apache.hadoop.hive.metastore.api.Table; | ||
| import org.apache.hadoop.hive.metastore.client.MetaStoreClientTest; | ||
| import org.apache.hadoop.hive.metastore.client.builder.DatabaseBuilder; | ||
| import org.apache.hadoop.hive.metastore.client.builder.TableBuilder; | ||
| import org.apache.hadoop.hive.metastore.conf.MetastoreConf; | ||
| import org.apache.hadoop.hive.metastore.events.DropDatabaseEvent; | ||
| import org.apache.hadoop.hive.metastore.events.DropTableEvent; | ||
| import org.apache.hadoop.hive.metastore.minihms.AbstractMetaStoreService; | ||
| import org.apache.thrift.TException; | ||
| import org.datanucleus.exceptions.NucleusException; | ||
| import org.junit.After; | ||
| import org.junit.Before; | ||
| import org.junit.BeforeClass; | ||
| import org.junit.Test; | ||
| import org.junit.experimental.categories.Category; | ||
| import org.junit.runner.RunWith; | ||
| import org.junit.runners.Parameterized; | ||
|
|
||
| import static org.junit.Assert.assertEquals; | ||
| import static org.junit.Assert.assertNotNull; | ||
| import static org.junit.Assert.fail; | ||
|
|
||
| @RunWith(Parameterized.class) | ||
| @Category(MetastoreCheckinTest.class) | ||
| public class TestRetryOnException extends MetaStoreClientTest { | ||
| protected static final String DB_NAME = "testdroptable"; | ||
| protected static final String TABLE_NAME = "test_drop_table"; | ||
| private final String testTempDir = | ||
| Paths.get(System.getProperty("java.io.tmpdir"), "testDropTable").toString(); | ||
| private AbstractMetaStoreService metaStore; | ||
| private HiveMetaStoreClient client; | ||
|
|
||
| public TestRetryOnException(String name, AbstractMetaStoreService metaStore) { | ||
| this.metaStore = metaStore; | ||
| } | ||
|
|
||
| @BeforeClass | ||
| public static void startMetaStores() { | ||
| Map<MetastoreConf.ConfVars, String> msConf = new HashMap<>(); | ||
| Map<String, String> extraConf = new HashMap<>(); | ||
| extraConf.put("metastore.transactional.event.listeners", AssertExTransactionListener.class.getName()); | ||
| startMetaStores(msConf, extraConf); | ||
| } | ||
|
|
||
| @Before | ||
| public void setUp() throws Exception { | ||
| AssertExTransactionListener.resetTest(); | ||
| client = metaStore.getClient(); | ||
| cleanDB(); | ||
| createDB(DB_NAME); | ||
| AssertExTransactionListener.startTest(); | ||
| } | ||
|
|
||
| @Test | ||
| public void testRetryOnException() throws Exception { | ||
| String location = metaStore.getExternalWarehouseRoot() + "/" + TABLE_NAME; | ||
| new TableBuilder() | ||
| .setDbName(DB_NAME) | ||
| .setTableName(TABLE_NAME) | ||
| .addCol("test_id", "int", "test col id") | ||
| .addCol("test_value", "string", "test col value") | ||
| .addTableParam("param_key", "param_value") | ||
| .setType(TableType.EXTERNAL_TABLE.name()) | ||
| .addTableParam("EXTERNAL", "TRUE") | ||
| .addStorageDescriptorParam("sd_param_key", "sd_param_value") | ||
| .setSerdeName(TABLE_NAME) | ||
| .setStoredAsSubDirectories(false) | ||
| .addSerdeParam("serde_param_key", "serde_param_value") | ||
| .setLocation(location) | ||
| .create(client, metaStore.getConf()); | ||
|
|
||
| Table table = client.getTable(DB_NAME, TABLE_NAME); | ||
| assertNotNull(table); | ||
| String tableName = TableName.getQualified(table.getCatName(), table.getDbName(), table.getTableName()); | ||
|
|
||
| assertEquals(0, AssertExTransactionListener.getCalls(tableName)); | ||
| client.dropTable(DB_NAME, TABLE_NAME); | ||
| assertEquals(AssertExTransactionListener.maxRetries, AssertExTransactionListener.getCalls(tableName)); | ||
| try { | ||
| client.getTable(DB_NAME, TABLE_NAME); | ||
| fail("Table " + tableName + " should be dropped"); | ||
| } catch (NoSuchObjectException nse) { | ||
| // expected | ||
| } | ||
|
|
||
| assertEquals(0, AssertExTransactionListener.getCalls(DB_NAME)); | ||
| client.dropDatabase(DB_NAME); | ||
| assertEquals(AssertExTransactionListener.maxRetries, AssertExTransactionListener.getCalls(tableName)); | ||
| try { | ||
| client.getDatabase(DB_NAME); | ||
| fail("Database " + DB_NAME + " should be dropped"); | ||
| } catch (NoSuchObjectException nse) { | ||
| // expected | ||
| } | ||
| } | ||
|
|
||
| public static class AssertExTransactionListener extends TransactionalMetaStoreEventListener { | ||
| static Map<String, Integer> calls = new HashMap<>(); | ||
| static int maxRetries = 5; | ||
| static boolean startChecking = false; | ||
|
|
||
| public AssertExTransactionListener(Configuration config) { | ||
| super(config); | ||
| } | ||
|
|
||
| @Override | ||
| public void onDropTable(DropTableEvent tableEvent) throws MetaException { | ||
| Table table = tableEvent.getTable(); | ||
| String tableName = TableName.getQualified(table.getCatName(), table.getDbName(), table.getTableName()); | ||
| Integer pre = calls.putIfAbsent(tableName, 1); | ||
| if (pre != null) { | ||
| calls.put(tableName, pre + 1); | ||
| } | ||
| // For a drop table call, we should see 5(maxRetries) retries in RetryingHMSHandler | ||
| assertException(startChecking && calls.get(tableName) < maxRetries); | ||
| } | ||
|
|
||
| @Override | ||
| public void onDropDatabase(DropDatabaseEvent dbEvent) throws MetaException { | ||
| String dbName = dbEvent.getDatabase().getName(); | ||
| Integer pre = calls.putIfAbsent(dbName, 1); | ||
| if (pre != null) { | ||
| calls.put(dbName, pre + 1); | ||
| } | ||
| assertException(startChecking && calls.get(dbName) < maxRetries); | ||
| } | ||
|
|
||
| private void assertException(boolean throwException) throws MetaException { | ||
| if (throwException) { | ||
| MetaException exception = new MetaException("An exception for RetryingHMSHandler to retry"); | ||
| exception.initCause(new NucleusException("Non-fatal exception")); | ||
| throw exception; | ||
| } | ||
| } | ||
|
|
||
| static void startTest() { | ||
| startChecking = true; | ||
| calls.clear(); | ||
| } | ||
|
|
||
| static void resetTest() { | ||
| startChecking = false; | ||
| calls.clear(); | ||
| } | ||
|
|
||
| static int getCalls(String key) { | ||
| return calls.get(key) != null ? calls.get(key) : 0; | ||
| } | ||
| } | ||
|
|
||
| @After | ||
| public void tearDown() throws Exception { | ||
| try { | ||
| if (client != null) { | ||
| try { | ||
| client.close(); | ||
| } catch (Exception e) { | ||
| } | ||
| } | ||
| } finally { | ||
| client = null; | ||
| } | ||
|
|
||
| Path path = new Path(testTempDir); | ||
| path.getFileSystem(metaStore.getConf()).delete(path, true); | ||
| } | ||
|
|
||
| protected void cleanDB() throws Exception{ | ||
| client.dropDatabase(DB_NAME, true, true, true); | ||
| metaStore.cleanWarehouseDirs(); | ||
| } | ||
|
|
||
| protected void createDB(String dbName) throws TException { | ||
| new DatabaseBuilder(). | ||
| setName(dbName). | ||
| create(client, metaStore.getConf()); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.