HIVE-26877: Parquet CTAS with JOIN on decimals with different precision/scale fail #6274
+275
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasrebele
approved these changes
Jan 22, 2026
| return new TimestampDataWriter((TimestampObjectInspector)inspector); | ||
| case DECIMAL: | ||
| return new DecimalDataWriter((HiveDecimalObjectInspector)inspector); | ||
| return new DecimalDataWriter((HiveDecimalObjectInspector) inspector, |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
ql/src/test/queries/clientpositive/parquet_join_dec_col_diff_pre_scale.q
Outdated
Show resolved
Hide resolved
ql/src/java/org/apache/hadoop/hive/ql/io/parquet/write/DataWritableWriter.java
Outdated
Show resolved
Hide resolved
Contributor
soumyakanti3578
left a comment
soumyakanti3578
left a comment
There was a problem hiding this comment.
Overall LGTM logically. Please consider resolving the remaining comments.
ql/src/test/queries/clientpositive/parquet_join_dec_col_diff_pre_scale.q
Outdated
Show resolved
Hide resolved
asf-ci-hive
added
tests pending
tests unstable
and removed
tests passed
tests pending
labels
mdayakar
force-pushed
the
HIVE-26877_Parquet_Decimal_Issue
branch
from
fd70f84 to
f3405b0
Compare
|
soumyakanti3578
approved these changes
Jan 23, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HIVE-26877: Parquet CTAS with JOIN on decimals with different precision/scale fail
What changes were proposed in this pull request?
While creating the writer object, if it is decimal type then using the precision and scale from schema instead of object inspector.
Why are the changes needed?
To fix the issue HIVE-26877
Does this PR introduce any user-facing change?
No
How was this patch tested?
Added q file test
mvn test -Dtest=TestMiniLlapLocalCliDriver -Dqfile=parquet_join_dec_col_diff_pre_scale.q -pl itests/qtest -Pitests