HIVE-28676: Support custom partition patterns in MSCK repair table #6271
+295
−50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for custom partitioning patterns to MSCK repair table.
asf-ci-hive
added
tests passed
tests pending
and removed
tests pending
tests passed
labels
|
Contributor
Author
|
@deniskuzZ Addressed all the review comments from the old PR. The hcat.dynamic.partitioning.custom.pattern setting needs to be used in hive-standalone-metastore-server in one place, so I moved the string with the name of the setting there(hcatalog-core and hive-exec depend on that module). I've rebased it on current master and rerun the MSCK unit tests, which all pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for custom partitioning patterns to MSCK repair table.
What changes were proposed in this pull request?
Adds support for custom partitioning patterns to MSCK repair table.
Why are the changes needed?
HCatStorer supports custom partitioning patterns when using dynamic partitioning, but Hive itself does not support this. This change adds support for non-pathological cases to Hive.
Does this PR introduce any user-facing change?
MSCK repair table with a configured custom partition pattern would previously ignore that pattern and error on finding nonstandard paths. With the code from this PR, it will respect the defined custom pattern when it extracts partition key values from the paths.
Is the change a dependency upgrade?
No
How was this patch tested?
A test was added to TestHiveMetastoreChecker to test the common kinds of custom patterns supported.
Adds support for custom partitioning patterns to MSCK repair table.