fix(web-app): point threshold user guide link to correct docs#4239
Open
orangeCatDeveloper wants to merge 1 commit into
Open
fix(web-app): point threshold user guide link to correct docs#4239orangeCatDeveloper wants to merge 1 commit into
orangeCatDeveloper wants to merge 1 commit into
Conversation
The threshold page bound its help link to the undefined i18n key alert.help.center.setting, so the link rendered the key as its href and opened the app 404 page. Use alert.help.setting.link, which already resolves to the alarm threshold docs in every locale.
orangeCatDeveloper
force-pushed
the
fix/alert-setting-userguide-link
branch
from
July 24, 2026 08:16
38ecd3b to
f4c5cbc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed
The User Guide link on the Threshold Rules page (
/alert/setting) openedthe app's own 404 page instead of the documentation.
The help component bound its link to the i18n key
alert.help.center.setting,which is not defined in any locale. The i18n pipe returns the key unchanged, so
the link rendered
href="alert.help.center.setting"and the router resolved itto
/exception/404. The correct keyalert.help.setting.linkalready exists inevery locale and points at the alarm threshold docs; this PR simply references
it.
One-line change in
alert-setting.component.html.Screenshots
Before (User Guide → app 404):
After (User Guide → alarm threshold docs):
Test plan
https://hertzbeat.apache.org/docs/help/alert_threshold.