HBASE-30291 Load backup HFile references once per cleaner run - #8539
Open
Sigma-Ma wants to merge 1 commit into
Open
HBASE-30291 Load backup HFile references once per cleaner run#8539Sigma-Ma wants to merge 1 commit into
Sigma-Ma wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA: https://issues.apache.org/jira/browse/HBASE-30291
What changes were proposed in this pull request?
This pull request changes
BackupHFileCleanerto load the referenced HFile names once inpreClean()and reuse the resulting snapshot for allgetDeletableFiles()calls in the same cleaner cycle.The snapshot is published only after loading completes. If loading the references fails, the snapshot is marked unavailable and all files are kept for that cleaner cycle.
The existing
previousCleaningCompletionTimestampprotection is preserved to prevent recently archived HFiles from being deleted before the next snapshot refresh.Tests are added to verify that:
getDeletableFiles()calls in one cleaner cycle load the references only once;Why are the changes needed?
BackupHFileCleaner#getDeletableFiles()is invoked concurrently for each non-empty archive directory. It currently scans the backup system tables on every invocation to load the same set of backed-up tables and bulk-loaded HFile references.On clusters with many regions, this causes tens of thousands of redundant system-table scans in a single cleaner cycle. The resulting I/O load can prevent the cleaner from keeping up, causing archived HFiles to accumulate.
Loading the references once per cleaner cycle removes these redundant scans without introducing a cross-cycle cache or changing the general
CleanerChoreframework.How was this patch tested?
The following checks were run successfully: