HBASE-30241 TestMobCloneSnapshotFromClientAfterSplittingRegion is fla…#8387
Open
liuxiaocs7 wants to merge 1 commit into
Open
HBASE-30241 TestMobCloneSnapshotFromClientAfterSplittingRegion is fla…#8387liuxiaocs7 wants to merge 1 commit into
liuxiaocs7 wants to merge 1 commit into
Conversation
…ky because a split may build whole-file HFileLinks instead of References
There was a problem hiding this comment.
Pull request overview
This PR addresses test flakiness around clone-snapshot-after-split by explicitly covering both split outcomes introduced by HBASE-26421: (1) splits that generate Reference files and (2) splits that generate whole-file HFileLinks. It strengthens existing coverage (HBASE-29111) and adds a complementary regression test for the all-HFileLink scenario described in HBASE-30241.
Changes:
- Ensure the existing “reference-file” split test deterministically produces
Referencefiles by major-compacting regions before splitting. - Add a new shared test base that constructs a split where daughter regions receive whole-file
HFileLinks (noReferences) and validates cloned table survivability after source+snapshot deletion and cleaner execution. - Add parameterized test entry points for both normal and MOB tables for the new all-
HFileLinksplit scenario.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestMobCloneSnapshotFromClientAfterSplittingRegionWithLinks.java | Adds MOB variant runner for the new all-HFileLink split + clone survivability test. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestCloneSnapshotFromClientAfterSplittingRegionWithLinks.java | Adds non-MOB runner for the new all-HFileLink split + clone survivability test. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/client/CloneSnapshotFromClientAfterSplittingRegionWithLinksTestBase.java | Introduces the deterministic all-HFileLink split test logic and assertions for clone independence after cleanup. |
| hbase-server/src/test/java/org/apache/hadoop/hbase/client/CloneSnapshotFromClientAfterSplittingRegionTestBase.java | Makes the existing “reference-file” split test deterministic by compacting before split to avoid falling into the all-HFileLink case. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Apache9
reviewed
Jun 21, 2026
| * (the regression HBASE-29111 guards against): here there is no parent-to-daughter mapping to | ||
| * record, and the cloned table must still be safe after the source table and snapshot are removed. | ||
| */ | ||
| public class CloneSnapshotFromClientAfterSplittingRegionWithLinksTestBase { |
Contributor
There was a problem hiding this comment.
We do not extend CloneSnapshotFromClientTestBase here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ky because a split may build whole-file HFileLinks instead of References