HBASE-30155 MobFileCleanerChore does not shut down its internal execu…#8222
Open
liuxiaocs7 wants to merge 2 commits into
Open
HBASE-30155 MobFileCleanerChore does not shut down its internal execu…#8222liuxiaocs7 wants to merge 2 commits into
liuxiaocs7 wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses HBASE-30155 by ensuring MobFileCleanerChore releases its internally managed thread pool when the chore is shut down, preventing lingering executor threads during master cleanup/shutdown.
Changes:
- Add a
cleanup()override inMobFileCleanerChoreto shut down the internalThreadPoolExecutor. - Add a small JUnit test that verifies
shutdown()transitions the internal executor to a shutdown state.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| hbase-server/src/main/java/org/apache/hadoop/hbase/mob/MobFileCleanerChore.java | Ensure the chore’s internal executor is shut down during ScheduledChore.cleanup(). |
| hbase-server/src/test/java/org/apache/hadoop/hbase/mob/TestMobFileCleanerChore.java | Add a unit test to validate executor shutdown behavior on chore shutdown. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Apache9
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…tor on cleanup