HBASE-29809 Unify region reopening methods to use throttled implement…#7818
HBASE-29809 Unify region reopening methods to use throttled implement…#7818liuxiaocs7 wants to merge 3 commits intoapache:masterfrom
Conversation
|
Hi, @ajkh88 and @charlesconnell, could you help take a look when free, thanks! |
| /** | ||
| * Create a new ReopenTableRegionsProcedure respecting the throttling configuration for the table. | ||
| * First check the table descriptor, then fall back to the global configuration. Only used in | ||
| * ModifyTableProcedure and in {@link HMaster#reopenRegionsThrottled}. |
There was a problem hiding this comment.
Are you sure about this javadoc change? This looks wrong. I think to make the link work property there need to be args, like {@link HMaster#reopenRegionsThrottled(TableName, ...}
There was a problem hiding this comment.
Thanks for your review, yes, these modifications are unnecessary and can be removed
| try { | ||
| LOG.warn("Reopening regions due to high storeFileRefCount. " | ||
| + "TableName: {} , noOfRegions: {}", tableName, regionNames.size()); | ||
| hMaster.reopenRegions(tableName, regionNames, NONCE_GENERATOR.getNonceGroup(), |
There was a problem hiding this comment.
I can't really comment on whether it's a good idea to throttle these reopens since I don't have enough context on this code path.
There was a problem hiding this comment.
Hi, @charlesconnell, thanks for your comments, RegionsRecoveryChore used to reopen region whose maxCompactedStoreFileRefCount metric large than the configured storeFileRefCountThreshold, if throttle feature is enabled, we can avoid reopen them at the same time. At the same time, the default behavior will remain consistent with previous
2 participants
…ation