HBASE-29815: Fix issue where backup integration tests are not running in IntelliJ

[kgeisz]

https://issues.apache.org/jira/browse/HBASE-29815

This pull request fixes an issue where IntegrationTestContinuousBackupRestore and IntegrationTestBackupRestore are able to run in the command line using bin/hbase, but they will not run in IntelliJ for in the command line using Maven. This issue is fixed by ensuring essential class variables for the integration tests are initialized, regardless of how the test is executed.

Note: IntegrationTestContinuousBackupRestore and IntegrationTestBackupRestore will still fail on this branch for different reasons due to HBASE-29825 and HBASE-29826.

[Copilot]

Pull request overview

This pull request fixes an issue where backup integration tests (IntegrationTestBackupRestore and IntegrationTestContinuousBackupRestore) fail to initialize essential test parameters when run via IntelliJ or Maven, though they work correctly when executed via the bin/hbase command-line tool.

Changes:

• Initialized static test parameter variables with sentinel value -1 to enable detection of uninitialized state
• Added initializeTestParameters() method to ensure test parameters are properly initialized from configuration when not set via command-line
• Refactored setUp() methods in concrete test classes to use the new initialization method

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
IntegrationTestBackupRestoreBase.java	Added sentinel initialization for static test parameters, created initializeTestParameters() method, removed unused variables, capitalized comment, and added missing import
IntegrationTestBackupRestore.java	Replaced direct util and conf initialization with call to initializeTestParameters()
IntegrationTestContinuousBackupRestore.java	Replaced direct util and conf initialization with call to initializeTestParameters()

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[taklwu]

thanks for the update, LGTM

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 33s		Docker mode activated.
-0 ⚠️	yetus	0m 3s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ HBASE-29164 Compile Tests _
+1 💚	mvninstall	3m 32s		HBASE-29164 passed
+1 💚	compile	0m 23s		HBASE-29164 passed
+1 💚	javadoc	0m 14s		HBASE-29164 passed
+1 💚	shadedjars	6m 15s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	3m 14s		the patch passed
+1 💚	compile	0m 23s		the patch passed
+1 💚	javac	0m 23s		the patch passed
+1 💚	javadoc	0m 12s		the patch passed
+1 💚	shadedjars	6m 18s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	0m 43s		hbase-it in the patch passed.
		22m 42s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7625/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#7625
JIRA Issue	HBASE-29815
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 070b39d3ba94 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-29164 / 6db6b9e
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7625/2/testReport/
Max. process+thread count	628 (vs. ulimit of 30000)
modules	C: hbase-it U: hbase-it
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7625/2/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 35s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ HBASE-29164 Compile Tests _
+1 💚	mvninstall	3m 37s		HBASE-29164 passed
+1 💚	compile	0m 36s		HBASE-29164 passed
+1 💚	checkstyle	0m 12s		HBASE-29164 passed
+1 💚	spotbugs	0m 28s		HBASE-29164 passed
+1 💚	spotless	0m 53s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+1 💚	mvninstall	3m 14s		the patch passed
+1 💚	compile	0m 34s		the patch passed
+1 💚	javac	0m 34s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 11s		the patch passed
+1 💚	spotbugs	0m 33s		the patch passed
+1 💚	hadoopcheck	12m 35s		Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚	spotless	0m 48s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 11s		The patch does not generate ASF License warnings.
		32m 22s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7625/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#7625
JIRA Issue	HBASE-29815
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname	Linux 041c545f4ab1 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-29164 / 6db6b9e
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	83 (vs. ulimit of 30000)
modules	C: hbase-it U: hbase-it
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7625/2/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.