HDFS-17956. Bound TestBackupNode.waitCheckpointDone with timeout - #8650
Open
pan3793 wants to merge 1 commit into
Open
HDFS-17956. Bound TestBackupNode.waitCheckpointDone with timeout#8650pan3793 wants to merge 1 commit into
pan3793 wants to merge 1 commit into
Conversation
Replace the unbounded do-while polling loop in waitCheckpointDone with GenericTestUtils.waitFor, capping at 60s. The loop previously slept indefinitely when a checkpoint never arrived, hanging the surefire fork until the 900s forkedProcessTimeoutInSeconds killed it, causing the consistent 'hdfs - other' CI failures on trunk since late July. Assisted-by: GLM 5.2
6 tasks
|
🎊 +1 overall
This message was automatically generated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Replace the unbounded do-while polling loop in
waitCheckpointDonewithGenericTestUtils.waitFor, capping the wait at 60 seconds.When a checkpoint never arrives, the loop sleeps indefinitely, hanging
the surefire fork until
forkedProcessTimeoutInSeconds(900s) kills it.The fork kill produces a generic "timeout in the fork" error with no
indication of which test hung. The bounded wait converts this into a
fast, clear
TimeoutExceptionnaming the checkpoint txid that neveradvanced.
How was this patch tested?
Verified via GitHub Actions CI on a fork branch. Before the change, the
fork hangs 900s with no indication of the culprit. After the change,
TestBackupNodefails within 60s with:For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?AI Tooling
If an AI tool was used:
<tool>"where
<tool>is the name of the AI tool used.https://www.apache.org/legal/generative-tooling.html
Contains content generated by GLM 5.2