Skip to content

HDFS-15491. Fix misplaced NumTransactionsBatchedInSync metrics documentation. - #8646

Open
joseluisll wants to merge 1 commit into
apache:trunkfrom
joseluisll:HDFS-15491
Open

HDFS-15491. Fix misplaced NumTransactionsBatchedInSync metrics documentation.#8646
joseluisll wants to merge 1 commit into
apache:trunkfrom
joseluisll:HDFS-15491

Conversation

@joseluisll

Copy link
Copy Markdown

Description of PR

HDFS-15491 reports that the NumTransactionsBatchedInSync* metrics documented for the JournalNode are absent from JournalNode JMX, and proposes adding the metric to JournalMetrics.java.

The metrics are not missing — they are documented in the wrong section.

The rows were added by HDFS-12320 (commit 423ebcaf510), which added the quantiles to NameNodeMetrics.java but documented them under JournalNode in Metrics.md. That issue was filed against the metrics, namenode components — the JournalNode was out of its scope, and no JournalNode change is needed here either.

The rows are also wrong in detail: the quantiles are registered with valueName = "count", so the emitted names end in ...thPercentileCount, not ...thPercentileLatencyMicros.

HDFS-13674 later documented the metric in the correct NameNodeActivity section but omitted the Num prefix, and left the JournalNode rows in place. The metric is currently documented twice, under two names, neither matching what is emitted.

Changes

  1. Remove the 18 NumTransactionsBatchedInSync* rows from the JournalNode section.
  2. Correct the NameNodeActivity row to `NumTransactionsBatchedInSync`*num*`s(50/75/90/95/99)thPercentileCount`.

Documentation only: 1 insertion, 19 deletions. No code or test changes.

How was this patch tested?

Documentation-only change; verified by inspection.

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation? — N/A
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0? — N/A
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files? — N/A

AI Tooling

If an AI tool was used:

Contains content generated by Claude Code.

…ntation.

The NumTransactionsBatchedInSync quantiles were documented in the
JournalNode section of Metrics.md by HDFS-12320, which added them to
NameNodeMetrics rather than JournalMetrics. The JournalNode was out of
scope for that issue, so the rows describe metrics it never emitted.
Remove them, and correct the NameNodeActivity row to use the registered
name, which carries the Num prefix and a Count suffix rather than
LatencyMicros.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@hadoop-yetus

Copy link
Copy Markdown

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 1m 9s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 markdownlint 0m 0s markdownlint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ trunk Compile Tests _
+1 💚 mvninstall 42m 22s trunk passed
+1 💚 mvnsite 2m 0s trunk passed
+1 💚 shadedclient 75m 32s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 1m 17s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 mvnsite 1m 31s the patch passed
+1 💚 shadedclient 30m 20s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 asflicense 0m 36s The patch does not generate ASF License warnings.
110m 50s
Subsystem Report/Notes
Docker ClientAPI=1.55 ServerAPI=1.55 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8646/1/artifact/out/Dockerfile
GITHUB PR #8646
Optional Tests dupname asflicense mvnsite codespell detsecrets markdownlint
uname Linux ce142bda8eb1 5.15.0-181-generic #191-Ubuntu SMP Fri May 22 19:09:02 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 2607d4b
Max. process+thread count 611 (vs. ulimit of 10000)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8646/1/console
versions git=2.43.0 maven=3.9.15
Powered by Apache Yetus 0.14.1 https://yetus.apache.org

This message was automatically generated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants