HDFS-15491. Fix misplaced NumTransactionsBatchedInSync metrics documentation. - #8646
Open
joseluisll wants to merge 1 commit into
Open
HDFS-15491. Fix misplaced NumTransactionsBatchedInSync metrics documentation.#8646joseluisll wants to merge 1 commit into
joseluisll wants to merge 1 commit into
Conversation
…ntation. The NumTransactionsBatchedInSync quantiles were documented in the JournalNode section of Metrics.md by HDFS-12320, which added them to NameNodeMetrics rather than JournalMetrics. The JournalNode was out of scope for that issue, so the rows describe metrics it never emitted. Remove them, and correct the NameNodeActivity row to use the registered name, which carries the Num prefix and a Count suffix rather than LatencyMicros. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
🎊 +1 overall
This message was automatically generated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
HDFS-15491 reports that the
NumTransactionsBatchedInSync*metrics documented for the JournalNode are absent from JournalNode JMX, and proposes adding the metric toJournalMetrics.java.The metrics are not missing — they are documented in the wrong section.
The rows were added by HDFS-12320 (commit
423ebcaf510), which added the quantiles toNameNodeMetrics.javabut documented them under JournalNode inMetrics.md. That issue was filed against themetrics, namenodecomponents — the JournalNode was out of its scope, and no JournalNode change is needed here either.The rows are also wrong in detail: the quantiles are registered with
valueName = "count", so the emitted names end in...thPercentileCount, not...thPercentileLatencyMicros.HDFS-13674 later documented the metric in the correct NameNodeActivity section but omitted the
Numprefix, and left the JournalNode rows in place. The metric is currently documented twice, under two names, neither matching what is emitted.Changes
NumTransactionsBatchedInSync*rows from the JournalNode section.`NumTransactionsBatchedInSync`*num*`s(50/75/90/95/99)thPercentileCount`.Documentation only: 1 insertion, 19 deletions. No code or test changes.
How was this patch tested?
Documentation-only change; verified by inspection.
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles? — N/AAI Tooling
If an AI tool was used:
Contains content generated by Claude Code.