YARN-11970: Clearing the node with port zero as well when unassign a node from label by Hean-Chhinling · Pull Request #8635 · apache/hadoop

Hean-Chhinling · 2026-07-27T16:29:09Z

Description of PR

When a label is created via YARN CLI e.g. yarn rmadmin -addToClusterNodeLabels "label3"
And assigned to nodes without specifying the port e.g. yarn rmadmin -replaceLabelsOnNode "nodeId,label3"
It added the NM and the port zero as well:

From {rm_host}/ws/v1/cluster/get-node-to-labels

<nodeToLabelsInfo>
	<nodeToLabels>
		<entry>
			<key>{nodeId}:8041</key>
			<value>
				<nodeLabelInfo>
					<name>label3</name>
					<exclusivity>true</exclusivity>
				</nodeLabelInfo>
			</value>
		</entry>
		<entry>
			<key>{nodeId}:0</key>
			<value>
				<nodeLabelInfo>
					<name>label3</name>
					<exclusivity>true</exclusivity>
				</nodeLabelInfo>
			</value>
		</entry>
	</nodeToLabels>
</nodeToLabelsInfo>

Therefore, YARN Capacity Scheduler UI should check and clear port zero as well.

Otherwise, the label could not be removed via the UI.

How was this patch tested?

Tested locally:

When created label via CLI
When created label via the UI

I could remove the label as expected.

For code changes:

Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

AI Tooling

If an AI tool was used:

The PR includes the phrase "Contains content generated by "
where is the name of the AI tool used.
My use of AI contributions follows the ASF legal policy
https://www.apache.org/legal/generative-tooling.html

…node from label

hadoop-yetus · 2026-07-27T18:54:08Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	24m 11s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
			_ trunk Compile Tests _
+1 💚	mvninstall	47m 33s		trunk passed
+1 💚	shadedclient	81m 58s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	1m 25s		the patch passed
-1 ❌	blanks	0m 0s	/blanks-eol.txt	The patch has 1 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1 💚	shadedclient	33m 8s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	asflicense	0m 48s		The patch does not generate ASF License warnings.
		143m 39s

Subsystem	Report/Notes
Docker	ClientAPI=1.55 ServerAPI=1.55 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8635/1/artifact/out/Dockerfile
GITHUB PR	#8635
Optional Tests	dupname asflicense shadedclient codespell detsecrets
uname	Linux 1f4db2a0318e 5.15.0-177-generic #187-Ubuntu SMP Sat Apr 11 22:54:33 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `edb09fe`
Max. process+thread count	568 (vs. ulimit of 10000)
modules	C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-capacity-scheduler-ui U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-capacity-scheduler-ui
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8635/1/console
versions	git=2.43.0 maven=3.9.15
Powered by	Apache Yetus 0.14.1 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2026-07-27T23:35:03Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 54s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 1s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
			_ trunk Compile Tests _
+1 💚	mvninstall	47m 52s		trunk passed
+1 💚	shadedclient	83m 10s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	1m 26s		the patch passed
-1 ❌	blanks	0m 0s	/blanks-eol.txt	The patch has 1 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1 💚	shadedclient	33m 12s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	asflicense	0m 46s		The patch does not generate ASF License warnings.
		121m 18s

Subsystem	Report/Notes
Docker	ClientAPI=1.55 ServerAPI=1.55 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8635/3/artifact/out/Dockerfile
GITHUB PR	#8635
Optional Tests	dupname asflicense shadedclient codespell detsecrets
uname	Linux 52666a9b46fd 5.15.0-177-generic #187-Ubuntu SMP Sat Apr 11 22:54:33 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `e832fff`
Max. process+thread count	583 (vs. ulimit of 10000)
modules	C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-capacity-scheduler-ui U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-capacity-scheduler-ui
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8635/3/console
versions	git=2.43.0 maven=3.9.15
Powered by	Apache Yetus 0.14.1 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2026-07-28T09:50:45Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 52s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
			_ trunk Compile Tests _
+1 💚	mvninstall	47m 7s		trunk passed
+1 💚	shadedclient	81m 57s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	1m 25s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	shadedclient	33m 0s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	asflicense	0m 48s		The patch does not generate ASF License warnings.
		119m 54s

Subsystem	Report/Notes
Docker	ClientAPI=1.55 ServerAPI=1.55 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8635/4/artifact/out/Dockerfile
GITHUB PR	#8635
Optional Tests	dupname asflicense shadedclient codespell detsecrets
uname	Linux cc93f14ede67 5.15.0-177-generic #187-Ubuntu SMP Sat Apr 11 22:54:33 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `fbd5e22`
Max. process+thread count	573 (vs. ulimit of 10000)
modules	C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-capacity-scheduler-ui U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-capacity-scheduler-ui
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8635/4/console
versions	git=2.43.0 maven=3.9.15
Powered by	Apache Yetus 0.14.1 https://yetus.apache.org

This message was automatically generated.

K0K0V0K · 2026-07-29T08:15:35Z

+      const nodeToLabelsReplacement = [{ nodeId, labels }];
+
+      if (!labelName) {
+        const [host, port] = nodeId.split(':');


In the future, if YARN fully supports IPv6, this code could become a problem.
Could you please make it compatible with IPv6 literals?

Thank for the review, @K0K0V0K.
I have added to check the lastIndex instead to support Ipv6 as well.

hadoop-yetus · 2026-07-29T10:21:30Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 0s		Docker mode activated.
-1 ❌	patch	0m 22s		#8635 does not apply to trunk. Rebase required? Wrong Branch? See https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute for help.

Subsystem	Report/Notes
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8635/6/console
versions	git=2.34.1
Powered by	Apache Yetus 0.14.1 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2026-07-29T10:26:40Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 24s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
			_ trunk Compile Tests _
+1 💚	mvninstall	25m 5s		trunk passed
+1 💚	shadedclient	41m 2s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 47s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	shadedclient	15m 42s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	asflicense	0m 28s		The patch does not generate ASF License warnings.
		59m 30s

Subsystem	Report/Notes
Docker	ClientAPI=1.55 ServerAPI=1.55 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8635/5/artifact/out/Dockerfile
GITHUB PR	#8635
Optional Tests	dupname asflicense shadedclient codespell detsecrets
uname	Linux 5069fda1b700 5.15.0-179-generic #189-Ubuntu SMP Tue May 5 18:20:56 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `f99db4d`
Max. process+thread count	641 (vs. ulimit of 10000)
modules	C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-capacity-scheduler-ui U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-capacity-scheduler-ui
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8635/5/console
versions	git=2.43.0 maven=3.9.15
Powered by	Apache Yetus 0.14.1 https://yetus.apache.org

This message was automatically generated.

Hean-Chhinling · 2026-07-30T15:56:53Z

Hello @K0K0V0K,
May I have your review on the updated code?

And @brumi1024 could I ask for your review as well?

slfan1989

host:0 is a host-wide wildcard mapping in CommonNodeLabelsManager, rather than merely a duplicate entry for the selected NodeManager. Replacing it with an empty label set updates every NM on that host.

YARN also allows the wildcard and an explicit NM assignment to differ, for example:

host:0    -> p1
host:8041 -> p2
host:8042 -> p1

With the current check, unassigning host:8041 also sends host:0 -> [], which removes p1 from the host and affects the other NM even though the user only changed host:8041.

Could we distinguish whether the wildcard mapping actually represents the assignment being removed and preserve it when other or different host-level assignments exist? Please add regression coverage for a different wildcard label and for multiple NMs on the same host.

…me host use it before removing the wildcard NM

Hean-Chhinling · 2026-07-31T11:28:14Z

Thank you so much @slfan1989 for the review!
My bad for overlook this case.

I have updated the code in my latest commit to check whether there is other NM on the same host and whether the label is the same before removing.

I have tested locally and written unit tests for it.

Please let me know what do you think!

hadoop-yetus · 2026-07-31T12:27:43Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 22s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
			_ trunk Compile Tests _
+1 💚	mvninstall	24m 56s		trunk passed
+1 💚	shadedclient	41m 0s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 49s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	shadedclient	15m 21s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	asflicense	0m 32s		The patch does not generate ASF License warnings.
		59m 12s

Subsystem	Report/Notes
Docker	ClientAPI=1.55 ServerAPI=1.55 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8635/7/artifact/out/Dockerfile
GITHUB PR	#8635
Optional Tests	dupname asflicense shadedclient codespell detsecrets
uname	Linux 384598c5f1e4 5.15.0-179-generic #189-Ubuntu SMP Tue May 5 18:20:56 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `b7795b4`
Max. process+thread count	637 (vs. ulimit of 10000)
modules	C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-capacity-scheduler-ui U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-capacity-scheduler-ui
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8635/7/console
versions	git=2.43.0 maven=3.9.15
Powered by	Apache Yetus 0.14.1 https://yetus.apache.org

This message was automatically generated.

YARN-11970: Clearing the node with port zero as well when unassign a …

edb09fe

…node from label

github-actions Bot added YARN trunk labels Jul 27, 2026

YARN-11970: Send port zero to be removed only when it exists

4814b79

YARN-11970: remove blank line

e832fff

Hean-Chhinling added 2 commits July 28, 2026 09:47

YARN-11970: remove blank line

33f0a0e

YARN-11970: rename variable to be more descriptive

fbd5e22

YARN-11970: Update unit test

f99db4d

K0K0V0K reviewed Jul 29, 2026

View reviewed changes

YARN-11970: Add supports incase of Ipv6

379dfd5

Hean-Chhinling requested a review from K0K0V0K July 30, 2026 12:39

slfan1989 requested changes Jul 31, 2026

View reviewed changes

YARN-11970: Add check whether it is the same label and other NM on sa…

b7795b4

…me host use it before removing the wildcard NM

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

YARN-11970: Clearing the node with port zero as well when unassign a node from label - #8635

YARN-11970: Clearing the node with port zero as well when unassign a node from label#8635
Hean-Chhinling wants to merge 8 commits into
apache:trunkfrom
Hean-Chhinling:trunk_YARN-11970

Hean-Chhinling commented Jul 27, 2026 •

edited

Loading

Uh oh!

hadoop-yetus commented Jul 27, 2026

Uh oh!

hadoop-yetus commented Jul 27, 2026

Uh oh!

hadoop-yetus commented Jul 28, 2026

Uh oh!

K0K0V0K Jul 29, 2026 •

edited

Loading

Uh oh!

Hean-Chhinling Jul 29, 2026

Uh oh!

hadoop-yetus commented Jul 29, 2026

Uh oh!

hadoop-yetus commented Jul 29, 2026

Uh oh!

Hean-Chhinling commented Jul 30, 2026

Uh oh!

slfan1989 left a comment

Uh oh!

Hean-Chhinling commented Jul 31, 2026 •

edited

Loading

Uh oh!

hadoop-yetus commented Jul 31, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

Hean-Chhinling commented Jul 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of PR

How was this patch tested?

For code changes:

AI Tooling

Uh oh!

hadoop-yetus commented Jul 27, 2026

Uh oh!

hadoop-yetus commented Jul 27, 2026

Uh oh!

hadoop-yetus commented Jul 28, 2026

Uh oh!

K0K0V0K Jul 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Hean-Chhinling Jul 29, 2026

Choose a reason for hiding this comment

Uh oh!

hadoop-yetus commented Jul 29, 2026

Uh oh!

hadoop-yetus commented Jul 29, 2026

Uh oh!

Hean-Chhinling commented Jul 30, 2026

Uh oh!

slfan1989 left a comment

Choose a reason for hiding this comment

Uh oh!

Hean-Chhinling commented Jul 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hadoop-yetus commented Jul 31, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Hean-Chhinling commented Jul 27, 2026 •

edited

Loading

K0K0V0K Jul 29, 2026 •

edited

Loading

Hean-Chhinling commented Jul 31, 2026 •

edited

Loading