HDFS-17935. [ARR] Separate router async handlers for active and observer#8548
Open
kokonguyen191 wants to merge 4 commits into
Open
HDFS-17935. [ARR] Separate router async handlers for active and observer#8548kokonguyen191 wants to merge 4 commits into
kokonguyen191 wants to merge 4 commits into
Conversation
|
💔 -1 overall
This message was automatically generated. |
Contributor
Author
|
Unrelated javadocs failure, though it has been popping up for a few pull requests now. Maybe it's time to fix it |
|
💔 -1 overall
This message was automatically generated. |
Contributor
Author
|
Hi @ZanderXu @KeeProMise @hfutatzhanghb, please take a look when you're free, thanks! |
ZanderXu
reviewed
Jun 16, 2026
ZanderXu
left a comment
ZanderXu
left a comment
Contributor
There was a problem hiding this comment.
Thanks @kokonguyen191 for your contribution.
This is a good idea. It can decouple the impact between the Active NameNode and Observer NameNodes on the RBF side, especially in scenarios where there are many Observer NameNodes.
However, it would be better to add a configuration to control whether this feature is enabled, because in most cases it is acceptable to use the same executor without differentiating between them.
|
💔 -1 overall
This message was automatically generated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Most router traffic are reads, and currently all traffic to a namespace is handled by one same executor, so high observer load can increase competition for active ops. It would be beneficial to split the handler pools into 2 separate sets, one for active, one for observer.
Added a simple unit test (LLM-gen for skeleton then rewrote) to count how many calls are proxied through which executor. Contains content generated by Codex/ChatGPT-5.5.
How was this patch tested?
UT. Have been running on production environment for months.
AI Tooling
If an AI tool was used:
where is the name of the AI tool used.
https://www.apache.org/legal/generative-tooling.html