Skip to content

HDFS-17916: DataStreamer#processDatanodeOrExternalError() fails to return byte arrays to ByteArrayManager (branch-3.5)#8516

Open
charlesconnell wants to merge 1 commit into
apache:branch-3.5from
HubSpot:HDFS-17916-branch-3.5
Open

HDFS-17916: DataStreamer#processDatanodeOrExternalError() fails to return byte arrays to ByteArrayManager (branch-3.5)#8516
charlesconnell wants to merge 1 commit into
apache:branch-3.5from
HubSpot:HDFS-17916-branch-3.5

Conversation

@charlesconnell

Copy link
Copy Markdown
Contributor

Description of PR

Backport of #8466

How was this patch tested?

see other PR

For code changes:

see other PR

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

AI Tooling

see other PR

If an AI tool was used:

…turn byte arrays to ByteArrayManager (apache#8466)

Contributed by Charles Connell
@steveloughran

Copy link
Copy Markdown
Contributor

Two test failures. Could they be related? If not, is there some (test?) change in trunk to cherrypick?

Test Result (2 failures )
org.apache.hadoop.hdfs.TestDFSClientRetries.testLeaseRenewAndDFSOutputStreamDeadLock
org.apache.hadoop.hdfs.TestDFSClientRetries.testLeaseRenewSocketTimeout

@charlesconnell

Copy link
Copy Markdown
Contributor Author

@steveloughran I don't think the test failures are related to the changes in this PR. I think that TestDFSClientRetries is flaky because the DFSClientFaultInjector is not reset after each test method. I'm not sure why this issue doesn't present in trunk, maybe the junit 4/5 difference could affect that. I don't see anything targeted to cherry-pick to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants