HDFS-17916: DataStreamer#processDatanodeOrExternalError() fails to return byte arrays to ByteArrayManager (branch-3.5)#8516
Open
charlesconnell wants to merge 1 commit into
Conversation
…turn byte arrays to ByteArrayManager (apache#8466) Contributed by Charles Connell
6 tasks
slfan1989
approved these changes
May 31, 2026
Contributor
|
Two test failures. Could they be related? If not, is there some (test?) change in trunk to cherrypick? |
Contributor
Author
|
@steveloughran I don't think the test failures are related to the changes in this PR. I think that TestDFSClientRetries is flaky because the DFSClientFaultInjector is not reset after each test method. I'm not sure why this issue doesn't present in trunk, maybe the junit 4/5 difference could affect that. I don't see anything targeted to cherry-pick to fix this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Backport of #8466
How was this patch tested?
see other PR
For code changes:
see other PR
LICENSE,LICENSE-binary,NOTICE-binaryfiles?AI Tooling
see other PR
If an AI tool was used:
where is the name of the AI tool used.
https://www.apache.org/legal/generative-tooling.html