Skip to content

GROOVY-12133: Implement matchBalanced utility to support Regex Balanced Groups#2669

Open
daniellansun wants to merge 1 commit into
masterfrom
GROOVY-12133
Open

GROOVY-12133: Implement matchBalanced utility to support Regex Balanced Groups#2669
daniellansun wants to merge 1 commit into
masterfrom
GROOVY-12133

Conversation

@daniellansun

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50.

Benchmark suite Current: dd245a4 Previous: 0534fdf Ratio
org.apache.groovy.bench.CalibrationBench.memoryPointerChase 1008.8321436109155 us/op 436.1891939906616 us/op 2.31

This comment was automatically generated by workflow using github-action-benchmark.

@codecov-commenter

codecov-commenter commented Jul 5, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.90909% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.5685%. Comparing base (77ca2fa) to head (dd245a4).
⚠️ Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
...java/org/codehaus/groovy/runtime/RegexSupport.java 90.4762% 0 Missing and 4 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##               master      #2669    +/-   ##
==============================================
  Coverage     68.5684%   68.5685%            
- Complexity      33800      33825    +25     
==============================================
  Files            1524       1524            
  Lines          128091     128212   +121     
  Branches        23283      23305    +22     
==============================================
+ Hits            87830      87913    +83     
- Misses          32467      32496    +29     
- Partials         7794       7803     +9     
Files with missing lines Coverage Δ
...g/codehaus/groovy/runtime/StringGroovyMethods.java 82.4627% <100.0000%> (+0.0437%) ⬆️
...java/org/codehaus/groovy/runtime/RegexSupport.java 88.8889% <90.4762%> (+8.8889%) ⬆️

... and 12 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

JMH summary — classic (commit eccf17a)

Speedup vs trailing 90-day baseline on gh-pages. Higher = faster.
1.00 = in line with history. Per-benchmark ratio, geomean within group.
Time-per-op units inverted so direction is consistent. The calibrated
column divides out this runner's speed vs the baseline hardware, as
measured by Groovy-independent pure-Java ruler benchmarks.

Group Speedup Calibrated n
bench 1.034 × 0.996 × 78
core 1.001 × 0.992 × 77
grails 0.983 × 0.985 × 80

Runner calibration (this run vs baseline hardware): bench 1.04× (26 rulers) · core-ag 1.01× (3 rulers) · core-hz 1.01× (3 rulers) · grails-ad 1.00× (3 rulers) · grails-ez 1.00× (3 rulers)

Baseline: dev/bench/jmh/<part>/classic/data.js on gh-pages, trailing 90 days. Daily dashboard · Per-suite raw data

@github-actions

github-actions Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

JMH summary — indy (commit eccf17a)

Speedup vs trailing 90-day baseline on gh-pages. Higher = faster.
1.00 = in line with history. Per-benchmark ratio, geomean within group.
Time-per-op units inverted so direction is consistent. The calibrated
column divides out this runner's speed vs the baseline hardware, as
measured by Groovy-independent pure-Java ruler benchmarks.

Group Speedup Calibrated n
bench 0.970 × 0.995 × 78
core 3.312 × 3.163 × 77
grails 2.212 × 2.102 × 80

⚠️ Runner speed differs ≥15% from the historical baseline hardware for: grails-ez. Raw speedups are not meaningful for those parts — use the calibrated column.

Runner calibration (this run vs baseline hardware): bench 0.96× (26 rulers) · core-ag 1.07× (3 rulers) · core-hz 1.02× (3 rulers) · grails-ad 0.93× (3 rulers) · grails-ez 1.16× (3 rulers)

Baseline: dev/bench/jmh/<part>/indy/data.js on gh-pages, trailing 90 days. Daily dashboard · Per-suite raw data

@sonarqubecloud

sonarqubecloud Bot commented Jul 5, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@testlens-app

testlens-app Bot commented Jul 5, 2026

Copy link
Copy Markdown

✅ All tests passed ✅

🏷️ Commit: dd245a4
▶️ Tests: 98562 executed
⚪️ Checks: 31/31 completed


Learn more about TestLens at testlens.app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants