GROOVY-11871: Support Maven Resolver based version of Grapes#2140
Open
paulk-asert wants to merge 1 commit intoapache:masterfrom
Open
GROOVY-11871: Support Maven Resolver based version of Grapes#2140paulk-asert wants to merge 1 commit intoapache:masterfrom
paulk-asert wants to merge 1 commit intoapache:masterfrom
Conversation
paulk-asert
force-pushed
the
grapeMaven
branch
from
d2a22cf to
e1ab08e
Compare
paulk-asert
changed the title
paulk-asert
force-pushed
the
grapeMaven
branch
7 times, most recently
from
202953e to
eb032c8
Compare
paulk-asert
force-pushed
the
grapeMaven
branch
2 times, most recently
from
89c2a9b to
6537392
Compare
paulk-asert
force-pushed
the
grapeMaven
branch
5 times, most recently
from
40b4096 to
39ca48b
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 32 out of 34 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
+142
to
+145
| static void processSerializedCategoryMethods(InputStream is) { | ||
| is.getText().readLines().each { | ||
| System.err.println(it.trim()) // TODO: implement this or delete it | ||
| } |
Comment on lines
+35
to
+37
| def pretty= writer.toString() | ||
| .replaceAll(/<\?xml[^>]*>/, '') // remove XML declaration | ||
| assert pretty == '<root attribute="1"><elem1>hello</elem1><elem2>world</elem2></root>' |
Comment on lines
+34
to
+37
| * def pretty= writer.toString() | ||
| * .replaceAll(/<\?xml[^>]*>/, '') // remove XML declaration | ||
| * assert pretty in ['<root1 a="5" b="7"><elem1>hello1</elem1><elem2>hello2</elem2><elem3 x="7"></elem3></root1>', | ||
| * '<root1 a="5" b="7"><elem1>hello1</elem1><elem2>hello2</elem2><elem3 x="7"/></root1>'] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provide an Apache Maven Resolver alternative backend implementation for Groovy Grapes.