Add spec coverage for AggregateTimestampProvider - #16164
Open
borinquenkid wants to merge 1 commit into
Open
Conversation
AggregateTimestampProvider was the only class in the timestamp package without test coverage. Also replaces iterator().next() with getFirst() per SequencedCollection (JDK 21). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 8.1.x #16164 +/- ##
==================================================
+ Coverage 53.4149% 53.4381% +0.0232%
- Complexity 19459 19471 +12
==================================================
Files 2081 2081
Lines 98993 98993
Branches 17361 17361
==================================================
+ Hits 52877 52900 +23
+ Misses 38566 38544 -22
+ Partials 7550 7549 -1
🚀 New features to boost your workflow:
|
✅ All tests passed ✅🏷️ Commit: a4218ff Learn more about TestLens at testlens.app. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AggregateTimestampProviderwas the only class inorg.grails.datastore.gorm.timestampwithout test coverage; addedAggregateTimestampProviderSpeccoveringsupportsCreating/createTimestampdelegation (single provider, first-match among multiple, none-support, no-providers-registered) and thetimestampProvidersgetter/setter.timestampProviders.iterator().next()withList.getFirst()(JDK 21SequencedCollection) inAggregateTimestampProvider.DefaultTimestampProvider.Test plan
./gradlew :grails-datamapping-core:test --tests "org.grails.datastore.gorm.timestamp.*"— all pass./gradlew :grails-datamapping-core:codeStyle— clean🤖 Generated with Claude Code