Skip to content

Add spec coverage for AggregateTimestampProvider - #16164

Open
borinquenkid wants to merge 1 commit into
8.1.xfrom
chore/8.1.x-datamapping-core-timestamp
Open

Add spec coverage for AggregateTimestampProvider#16164
borinquenkid wants to merge 1 commit into
8.1.xfrom
chore/8.1.x-datamapping-core-timestamp

Conversation

@borinquenkid

Copy link
Copy Markdown
Member

Summary

  • AggregateTimestampProvider was the only class in org.grails.datastore.gorm.timestamp without test coverage; added AggregateTimestampProviderSpec covering supportsCreating/createTimestamp delegation (single provider, first-match among multiple, none-support, no-providers-registered) and the timestampProviders getter/setter.
  • Replaced timestampProviders.iterator().next() with List.getFirst() (JDK 21 SequencedCollection) in AggregateTimestampProvider.
  • Minor javadoc whitespace cleanup in DefaultTimestampProvider.

Test plan

  • ./gradlew :grails-datamapping-core:test --tests "org.grails.datastore.gorm.timestamp.*" — all pass
  • ./gradlew :grails-datamapping-core:codeStyle — clean

🤖 Generated with Claude Code

AggregateTimestampProvider was the only class in the timestamp package
without test coverage. Also replaces iterator().next() with getFirst()
per SequencedCollection (JDK 21).

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings August 18, 2026 16:00

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@codecov

codecov Bot commented Aug 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.4381%. Comparing base (75cd618) to head (a4218ff).

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##                8.1.x     #16164        +/-   ##
==================================================
+ Coverage     53.4149%   53.4381%   +0.0232%     
- Complexity      19459      19471        +12     
==================================================
  Files            2081       2081                
  Lines           98993      98993                
  Branches        17361      17361                
==================================================
+ Hits            52877      52900        +23     
+ Misses          38566      38544        -22     
+ Partials         7550       7549         -1     
Files with missing lines Coverage Δ
...ore/gorm/timestamp/AggregateTimestampProvider.java 100.0000% <100.0000%> (+100.0000%) ⬆️
...store/gorm/timestamp/DefaultTimestampProvider.java 100.0000% <ø> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@testlens-app

testlens-app Bot commented Aug 18, 2026

Copy link
Copy Markdown

✅ All tests passed ✅

🏷️ Commit: a4218ff
▶️ Tests: 62792 executed
⚪️ Checks: 77/77 completed


Learn more about TestLens at testlens.app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants