Clarify exception resolver request logging metadata#15811
Open
jamesfredley wants to merge 1 commit into
Open
Conversation
The runtime default is environment-dependent: request parameters log in development and remain disabled otherwise. Remove the unconditional metadata default and describe the actual behavior. Assisted-by: Hephaestus:openai/gpt-5.5 oracle codex-review
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Spring configuration metadata for grails.exceptionresolver.logRequestParameters to avoid advertising an unconditional default when the runtime default is environment-dependent, improving accuracy for IDE/config metadata consumers.
Changes:
- Removed the unconditional
defaultValuefromgrails.exceptionresolver.logRequestParametersmetadata. - Updated the property description to document the development vs non-development default behavior.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 8.0.x #15811 +/- ##
==================================================
- Coverage 49.4842% 49.4766% -0.0076%
+ Complexity 16697 16695 -2
==================================================
Files 1947 1947
Lines 92474 92474
Branches 16152 16152
==================================================
- Hits 45760 45753 -7
- Misses 39606 39612 +6
- Partials 7108 7109 +1 🚀 New features to boost your workflow:
|
✅ All tests passed ✅🏷️ Commit: 4febf42 Learn more about TestLens at testlens.app. |
jdaugherty
requested changes
Jul 2, 2026
jdaugherty
left a comment
Contributor
There was a problem hiding this comment.
This change should be made against 7.0.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Problem
The runtime default for
grails.exceptionresolver.logRequestParametersis environment-dependent: request-parameter logging is enabled in development and disabled everywhere else.The Spring configuration metadata, however, advertised a single unconditional
defaultValue. IDEs and config-metadata consumers that read that value would present a default that does not match what actually happens at runtime outside development.The Fix
Make the published metadata tell the truth instead of a misleading constant.
defaultValue.Files
grails-web-core/.../META-INF/spring-configuration-metadata.json- drop the hard-coded default, describe the dev/non-dev behavior.Testing
:grails-web-core:processResourcessucceeds and the emitted metadata forgrails.exceptionresolver.logRequestParametershas nodefaultValueand carries the environment-dependent description.