Merge grails-spring-security, grails-mail, and grails-redis#15792
Merge grails-spring-security, grails-mail, and grails-redis#15792jdaugherty wants to merge 5074 commits into
Conversation
Update to Grails 7.0.0-RC2
ci: update release drafter
ci: add commit hash for vote templates
ci: add release abort workflow & update verification script to check svn artifacts
chore: adjust verification script to not error when no differences remain
Add missing new line
remove references to Grails 3 from CAS plugin documentation
Rebased 7.0.x
chore: merge 5.0.0-RC2->5.0.x; bump to 5.0.0-SNAPSHOT
chore: merge 7.0.0-RC2->7.0.x; bump to 7.0.0-SNAPSHOT
chore: post release scripts
73c3e17 to
47f96da
Compare
|
@jamesfredley since this is a contribution of code from an external source, you must review it as an ASF member. |
|
As an ASF member I approve the contribution of this apache 2.0 licensed code being included in grails-core |
|
Reviewing it now |
|
|
||
| /** | ||
| */ | ||
| @Ignore // if not ignored, this spec expects that additional redis instances are running on localhost ports 6380 and 6381 and will fail without them |
There was a problem hiding this comment.
This leaves the multi-connection Redis coverage disabled. Since the PR is adding Redis CI coverage, the multi-pool wiring should either be exercised via testcontainers/CI-provisioned Redis instances or this disabled test should not be counted as covered behavior.
There was a problem hiding this comment.
This is out of scope of this change. I'm happy to make an issue for this, but we're just trying to merge libraries and I've already done enough on fixing the existing problems.
|
Finding 4 - new Spring Security and Redis CI jobs are not publish gates. .github/workflows/gradle.yml has publish depend on publishGradle, �uild, unctional, hibernate5Functional, and mongodbFunctional, but not the new security or |
|
@jamesfredley good catch on the path renames. I've found a few other issues as a result and expanded our verification scripts to catch these cases in the future. |
This was a good catch. I've updated the PR for this. |
|
@jamesfredley I believe all of your feedback has been implemented. On the slack topic, I don't see anything different about the imported SVGs. It seems like a concern separate from this PR as they're the same SVGs that are in grails-core already / part of the application generation. |
✅ All tests passed ✅🏷️ Commit: b30b80a Learn more about TestLens at testlens.app. |
Per vote https://lists.apache.org/thread/72rsnnnpcqdn642478xwd8go42rlpt6y , this merges grails-mail, grails-spring-security, and grails-redis.
Some highlights of this PR:
grails-testing-support-redisto facilitate running the redis based tests like the mongodb tests.wait { }After merging this to 7.0.x, I will merge all the way up to 8.0.x and then pull in the 8.x specific changes.