test: add unit and TCK tests for GormRegistry O(M+N) scaling#15781
Closed
borinquenkid wants to merge 1 commit into
Closed
test: add unit and TCK tests for GormRegistry O(M+N) scaling#15781borinquenkid wants to merge 1 commit into
borinquenkid wants to merge 1 commit into
Conversation
This was referenced Jun 27, 2026
e0e18f3 to
04d8d8f
Compare
5e565ae to
00b0fe6
Compare
04d8d8f to
24dd795
Compare
00b0fe6 to
894bd24
Compare
24dd795 to
b49c19f
Compare
14704c2 to
1dd696a
Compare
Add comprehensive test coverage for the new GormRegistry infrastructure: - GormRegistrySpec, GormRegistryConcurrencySpec, GormRegistryEntityRegistrationSpec - GormApiResolverSpec, GormApiFactorySpec, GormEnhancerAllQualifiersSpec - GormStaticApiSpec, GormInstanceApiSpec, TenantContextProfilingSpec - CurrentTenantHolderSpec, TenantsSpec, MultiTenantEventListenerSpec - TransactionalTransformSpec, ServiceTransformSpec, DefaultTransactionTemplateFactorySpec - Expanded TCK: multi-datasource, multi-tenant, discriminator, schema-per-tenant scenarios Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1dd696a to
c5d67bd
Compare
🚨 TestLens detected 51 failed tests 🚨Here is what you can do:
Test SummaryCI / Build Grails-Core (macos-latest, 21) > :grails-data-graphql-core:test
CI / Build Grails-Core (macos-latest, 21) > :grails-datamapping-core:test
CI / Build Grails-Core (ubuntu-latest, 21) > :grails-data-graphql-core:test
CI / Build Grails-Core (ubuntu-latest, 21) > :grails-datamapping-core:test
CI / Build Grails-Core (ubuntu-latest, 25) > :grails-data-graphql-core:test
CI / Build Grails-Core (windows-latest, 25) > :grails-data-graphql-core:test
CI / Build Grails-Core Rerunning all Tasks (ubuntu-latest, 21) > :grails-data-graphql-core:test
🏷️ Commit: c5d67bd Test Failures (first 10 of 51)DeleteEntityDataFetcherSpec > test get (:grails-data-graphql-core:test in CI / Build Grails-Core (macos-latest, 21))DeleteEntityDataFetcherSpec > test get invalid (:grails-data-graphql-core:test in CI / Build Grails-Core (macos-latest, 21))EntityDataFetcherSpec > test get (:grails-data-graphql-core:test in CI / Build Grails-Core (macos-latest, 21))EntityDataFetcherSpec > test pagination (:grails-data-graphql-core:test in CI / Build Grails-Core (macos-latest, 21))GormEnhancerAllQualifiersSpec > registerEntity can resolve through injected registry without touching global singleton (:grails-datamapping-core:test in CI / Build Grails-Core (macos-latest, 21))GormRegistrySpec > test withTenant and exists with multi-tenant entity in DISCRIMINATOR mode (:grails-datamapping-core:test in CI / Build Grails-Core (macos-latest, 21))
SingleEntityDataFetcherSpec > test get (:grails-data-graphql-core:test in CI / Build Grails-Core (macos-latest, 21))SoftDeleteEntityDataFetcherSpec > test get (:grails-data-graphql-core:test in CI / Build Grails-Core (macos-latest, 21))TenantContextProfilingSpec > profile tenant wrapping overhead (:grails-datamapping-core:test in CI / Build Grails-Core (macos-latest, 21))UpdateEntityDataFetcherSpec > test get (:grails-data-graphql-core:test in CI / Build Grails-Core (macos-latest, 21))Muted Tests (first 20 of 51)Select tests to mute in this pull request:
Reuse successful test results:
Click the checkbox to trigger a rerun:
Learn more about TestLens at testlens.app. |
Member
Author
|
Superseded by the consolidated GormRegistry work. The net-new core-class unit specs from this PR were harvested into #15790 (verified green against the core-impl implementation); the remaining changes here were adaptations of existing TCK/core specs to the divergent adapter stack (#15782–#15787, now closed) and do not apply to core-impl (#15780). Closing as superseded; the branch is retained for reference (not deleted). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Full test suite for the GormRegistry implementation in #15780. Separated into its own PR so reviewers can evaluate design and coverage independently.
Unit tests —
grails-datamapping-core:GormRegistrySpec— lifecycle, registration, removal, factory fallbackGormRegistryConcurrencySpec— concurrent registration and lookup under loadGormRegistryEntityRegistrationSpec— entity → datastore → API wiringGormApiResolverSpec— qualifier routing, fallback, multi-tenant mode dispatchGormApiFactorySpec/DefaultGormApiFactorySpec— factory delegationGormStaticApiSpec/GormInstanceApiSpec— API execution and qualifier propagationGormEnhancerAllQualifiersSpec— all qualifier expansion scenariosCurrentTenantHolderSpec/TenantsSpec— thread-safe tenant bindingTenantContextProfilingSpec— DISCRIMINATOR vs DATABASE/SCHEMA mode routingMultiTenantEventListenerSpec— tenant lifecycle eventsTransactionalTransformSpec/ServiceTransformSpec— AST transform correctnessDefaultTransactionTemplateFactorySpec— transaction template pluggabilityGormStaticApiRegistrySpec,GormInstanceApiRegistrySpec,GormValidationApiRegistrySpecTCK expansion —
grails-datamapping-tck:ALLqualifier expansionDataTestSetupInterceptorregistry lifecycle in Spock testsTest plan
./gradlew :grails-datamapping-core:testpasses./gradlew :grails-datamapping-tck:testpassesStack
feat/gorm-datastore-infra)feat/gorm-registry-core-impl)🤖 Generated with Claude Code