test: make IgniteStoreMapReduceTest deterministic#309
Open
Jack-LuoHongyi wants to merge 1 commit intoapache:masterfrom
Open
test: make IgniteStoreMapReduceTest deterministic#309Jack-LuoHongyi wants to merge 1 commit intoapache:masterfrom
Jack-LuoHongyi wants to merge 1 commit intoapache:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
org.apache.gora.ignite.mapreduce.IgniteStoreMapReduceTest#testCountQueryagainst nondeterministic insert orderingDetection
mvn -pl gora-ignite edu.illinois:nondex-maven-plugin:2.1.7:nondex -Dtest=org.apache.gora.ignite.mapreduce.IgniteStoreMapReduceTest#testCountQuery -DnondexRuns=100expected:<10> but was:<0>IgniteSQLBuilderiteratedHashMapentries without a defined order, so column/parameter ordering could vary between runs, leading the count MapReduce job to read zero rows intermittently.Fix
IgniteSQLBuilderto make schema writes deterministicMapReduceTestUtils.testCountQuerylogic; only the runner is set to local MR to avoid MiniMR/MiniDFS timeouts, without removing any verificationValidation (same intensity as Detection)
mvn -pl gora-ignite -Dtest=org.apache.gora.ignite.mapreduce.IgniteStoreMapReduceTest#testCountQuery test(pass)mvn -pl gora-ignite edu.illinois:nondex-maven-plugin:2.1.7:nondex -Dtest=org.apache.gora.ignite.mapreduce.IgniteStoreMapReduceTest#testCountQuery -DnondexRuns=100(all pass)No Scope/Standard Reduction
WebPageDataCreator), same MapReduce assertions (expected count == 10)